Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, msramek+watch_chromium.org, vakh+watch_chromium.org, vmpstr+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, jam, hidehiko+watch_chromium.org, bnc+watch_chromium.org, lhchavez+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, mlamouri+watch-geolocation_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, net-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, timvolodine, pam+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, Matt Giuca, elijahtaylor+arcwatch_chromium.org, hashimoto+watch_chromium.org, tfarina, mcasas+geolocation_chromium.org, victorhsieh+watch_chromium.org, danakj+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SetWithoutPathExpansion BUG=

Patch Set 1 #

Patch Set 2 : Fix Compilation Errors #

Patch Set 3 : Fix More Errors #

Patch Set 4 : Fix CrOS Error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -535 lines) Patch
M base/values.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M base/values.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_mapping.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 25 chunks +28 lines, -50 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc View 5 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_bookmarks_handler_unittest.cc View 2 chunks +24 lines, -17 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_whitelist_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/network_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/platform_keys_natives.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/log.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_device_client.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_shill_ipconfig_client.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 2 chunks +4 lines, -1 line 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 2 4 chunks +10 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chromeos/dbus/shill_profile_client_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chromeos/dbus/shill_service_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/network/device_state.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M chromeos/network/network_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_ui_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_mapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_merger.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 8 chunks +13 lines, -9 lines 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/policy_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_pref.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M components/policy/core/common/policy_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/registry_dict.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync_preferences/pref_model_associator.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M components/sync_preferences/pref_model_associator_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M components/url_matcher/url_matcher_factory_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M components/wifi/wifi_service_mac.mm View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/service_manager/merge_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/values_util_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 2 3 chunks +11 lines, -12 lines 0 comments Download
M ios/chrome/browser/autofill/autofill_agent.mm View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_info_cache.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_info_cache.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 15 chunks +80 lines, -85 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/spdy/core/spdy_header_block.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M services/preferences/tracked/pref_hash_filter_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 2 2 chunks +14 lines, -10 lines 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/test/error_generation_unittest.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M tools/json_schema_compiler/test/simple_api_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/test/test_util.h View 1 chunk +15 lines, -12 lines 0 comments Download
M tools/json_schema_compiler/test/test_util.cc View 1 chunk +22 lines, -18 lines 0 comments Download
M ui/app_list/search/history_data_store.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2838893002 Patch 100001

Messages

Total messages: 17 (17 generated)
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-25 20:53:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843813002/1
3 years, 8 months ago (2017-04-25 20:53:44 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-25 21:16:37 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/86975)
3 years, 8 months ago (2017-04-25 21:16:38 UTC) #4
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-25 21:41:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843813002/20001
3 years, 8 months ago (2017-04-25 21:42:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-25 21:56:21 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/83281) ios-simulator-xcode-clang on ...
3 years, 8 months ago (2017-04-25 21:56:22 UTC) #8
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 13:33:45 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843813002/40001
3 years, 8 months ago (2017-04-26 13:34:05 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 14:28:01 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/326890)
3 years, 8 months ago (2017-04-26 14:28:02 UTC) #12
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 16:32:39 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843813002/60001
3 years, 8 months ago (2017-04-26 16:33:12 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 18:04:03 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/439232)
3 years, 8 months ago (2017-04-26 18:04:05 UTC) #16
jdoerrie
3 years, 7 months ago (2017-05-18 06:14:03 UTC) #17 
Description was changed from

==========
Remove SetWithoutPathExpansion

BUG=
==========

to

==========
Remove SetWithoutPathExpansion

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698