Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)
Patch Set: Fix CrOS Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
diff --git a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
index 7a3387b695ed2227108d0116f33fcbf0cff0b2ca..14f38e3500c1c73588574f2c1ae14208ea4f3bad 100644
--- a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
+++ b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h"
#include <memory>
+#include <utility>
#include "base/json/json_writer.h"
#include "base/message_loop/message_loop.h"
@@ -23,9 +24,9 @@ const char kAccountId[] = "account@gmail.com";
std::string BuildResponse() {
base::DictionaryValue dict;
- base::DictionaryValue* permission_dict = new base::DictionaryValue;
+ auto permission_dict = base::MakeUnique<base::DictionaryValue>();
permission_dict->SetStringWithoutPathExpansion("id", "requestid");
- dict.SetWithoutPathExpansion("permissionRequest", permission_dict);
+ dict.SetWithoutPathExpansion("permissionRequest", std::move(permission_dict));
std::string result;
base::JSONWriter::Write(dict, &result);
return result;

Powered by Google App Engine
This is Rietveld 408576698