Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: ipc/ipc_message_utils_unittest.cc

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)
Patch Set: Fix CrOS Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_unittest.cc ('k') | net/http/http_server_properties_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils_unittest.cc
diff --git a/ipc/ipc_message_utils_unittest.cc b/ipc/ipc_message_utils_unittest.cc
index 4561c2e5cb9380b8139cd03ae75e2cb59ed52531..28b637894adc590ebf69e77e5bce74a75aa99d14 100644
--- a/ipc/ipc_message_utils_unittest.cc
+++ b/ipc/ipc_message_utils_unittest.cc
@@ -98,13 +98,13 @@ TEST(IPCMessageUtilsTest, StackVector) {
// Tests that PickleSizer and Pickle agree on the size of a complex base::Value.
TEST(IPCMessageUtilsTest, ValueSize) {
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue);
- value->SetWithoutPathExpansion("foo", new base::Value(42));
- value->SetWithoutPathExpansion("bar", new base::Value(3.14));
- value->SetWithoutPathExpansion("baz", new base::Value("hello"));
+ value->SetIntegerWithoutPathExpansion("foo", 42);
+ value->SetDoubleWithoutPathExpansion("bar", 3.14);
+ value->SetStringWithoutPathExpansion("baz", "hello");
value->SetWithoutPathExpansion("qux", base::MakeUnique<base::Value>());
std::unique_ptr<base::DictionaryValue> nested_dict(new base::DictionaryValue);
- nested_dict->SetWithoutPathExpansion("foobar", new base::Value(5));
+ nested_dict->SetIntegerWithoutPathExpansion("foobar", 5);
value->SetWithoutPathExpansion("nested", std::move(nested_dict));
std::unique_ptr<base::ListValue> list_value(new base::ListValue);
« no previous file with comments | « ipc/ipc_message_unittest.cc ('k') | net/http/http_server_properties_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698