Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chromeos/dbus/shill_ipconfig_client_unittest.cc

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)
Patch Set: Fix CrOS Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_ipconfig_client_unittest.cc
diff --git a/chromeos/dbus/shill_ipconfig_client_unittest.cc b/chromeos/dbus/shill_ipconfig_client_unittest.cc
index dd79e2ce43c35bac347e3d442651986b14bc7d5e..43653580c75e750e30dc1631dbc6280a1443096f 100644
--- a/chromeos/dbus/shill_ipconfig_client_unittest.cc
+++ b/chromeos/dbus/shill_ipconfig_client_unittest.cc
@@ -105,9 +105,8 @@ TEST_F(ShillIPConfigClientTest, GetProperties) {
// Create the expected value.
base::DictionaryValue value;
- value.SetWithoutPathExpansion(shill::kAddressProperty,
- new base::Value(kAddress));
- value.SetWithoutPathExpansion(shill::kMtuProperty, new base::Value(kMtu));
+ value.SetStringWithoutPathExpansion(shill::kAddressProperty, kAddress);
+ value.SetIntegerWithoutPathExpansion(shill::kMtuProperty, kMtu);
// Set expectations.
PrepareForMethodCall(shill::kGetPropertiesFunction,
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698