Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chromeos/network/network_configuration_handler_unittest.cc

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)
Patch Set: Fix CrOS Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler_unittest.cc
diff --git a/chromeos/network/network_configuration_handler_unittest.cc b/chromeos/network/network_configuration_handler_unittest.cc
index bfe347164d14e78b9bed054b587d21c9dc109b68..190c02aef33d25e6f99a595d25e6b967f5c741f0 100644
--- a/chromeos/network/network_configuration_handler_unittest.cc
+++ b/chromeos/network/network_configuration_handler_unittest.cc
@@ -479,9 +479,8 @@ TEST_F(NetworkConfigurationHandlerTest, CreateConfiguration) {
std::string profile = "profile path";
base::DictionaryValue value;
shill_property_util::SetSSID(networkName, &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value(profile));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, profile);
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath(profile), _, _, _))
@@ -500,9 +499,8 @@ TEST_F(NetworkConfigurationHandlerTest, RemoveConfiguration) {
std::string type = "wifi";
base::DictionaryValue value;
shill_property_util::SetSSID("Service", &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value("profile2"));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, "profile2");
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath("profile2"), _, _, _))
.WillOnce(
@@ -551,9 +549,8 @@ TEST_F(NetworkConfigurationHandlerTest, RemoveConfigurationFromCurrentProfile) {
std::string type = "wifi";
base::DictionaryValue value;
shill_property_util::SetSSID("Service", &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value("profile2"));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, "profile2");
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath("profile2"), _, _, _))
.WillOnce(
« no previous file with comments | « chromeos/network/managed_network_configuration_handler_unittest.cc ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698