Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DCHECK_op respectively
in third_party/WebKit/Source/platform/wtf

BUG=707661
Review-Url: https://codereview.chromium.org/2839663003
Cr-Commit-Position: refs/heads/master@{#470188}
Committed: https://chromium.googlesource.com/chromium/src/+/0cf75135e125604870a9eb91e4178ba18398d8f3

[Hwanseung Lee, 2017-04-25 15:34:47]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 15:35:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 15:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:43:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Hwanseung Lee, 2017-04-30 13:43:37]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 13:43:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 14:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 14:08:05]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Hwanseung Lee, 2017-05-01 00:17:06]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 00:17:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 02:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 02:17:33]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-05-08 01:34:02]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 01:34:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 02:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 02:53:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2017-05-08 05:47:04]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:47:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:46:10]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-05-08 11:06:55]

Description was changed from

==========
wtf assert

BUG=
==========

to

==========
Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DCHECK_op respectively
in third_party/WebKit/Source/platform/wtf

BUG=707661
==========

[Hwanseung Lee, 2017-05-08 11:06:56]

hs1217.lee@samsung.com changed reviewers:
+ tkent@chromium.org

[Hwanseung Lee, 2017-05-08 11:07:08]

Patchset #3 (id:40001) has been deleted

[Hwanseung Lee, 2017-05-08 11:07:16]

Patchset #2 (id:20001) has been deleted

[Hwanseung Lee, 2017-05-08 11:07:54]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 11:08:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 11:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 11:11:20]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-05-08 12:13:12]

PTAL, thank you.

[tkent, 2017-05-08 14:31:04]

lgtm

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc (right):

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc:492: DCHECK(IsClamped());
You shouldn't change indentation.

However, if this is caused by |git cl format|, it's acceptable.  Indentation in
this file is already broken.

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc (right):

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc:284: 
This change is unnecessary.

[Hwanseung Lee, 2017-05-08 23:31:03]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-05-08 23:31:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2839663003/#ps80001
(title: "fix indentation")

[Hwanseung Lee, 2017-05-08 23:31:13]

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc (right):

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc:492: DCHECK(IsClamped());
On 2017/05/08 14:31:03, tkent wrote:
> You shouldn't change indentation.
> 
> However, if this is caused by |git cl format|, it's acceptable.  Indentation
in
> this file is already broken.

Done.

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc (right):

https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc:284: 
On 2017/05/08 14:31:04, tkent wrote:
> This change is unnecessary.

Done.

[commit-bot: I haz the power, 2017-05-08 23:35:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:32]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Hwanseung Lee, 2017-05-09 01:25:02]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-05-09 01:25:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:12:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494293102135670,
"parent_rev": "5bd290cfb95fea92767b072349c8bf553451a0bd", "commit_rev":
"0cf75135e125604870a9eb91e4178ba18398d8f3"}

[commit-bot: I haz the power, 2017-05-09 04:12:57]

Description was changed from

==========
Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DCHECK_op respectively
in third_party/WebKit/Source/platform/wtf

BUG=707661
==========

to

==========
Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DCHECK_op respectively
in third_party/WebKit/Source/platform/wtf

BUG=707661

Review-Url: https://codereview.chromium.org/2839663003
Cr-Commit-Position: refs/heads/master@{#470188}
Committed:
https://chromium.googlesource.com/chromium/src/+/0cf75135e125604870a9eb91e417...
==========

[commit-bot: I haz the power, 2017-05-09 04:12:58]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0cf75135e125604870a9eb91e417...