Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
Review-Url: https://codereview.chromium.org/2839123003
Cr-Commit-Position: refs/heads/master@{#467908}
Committed: https://chromium.googlesource.com/chromium/src/+/322942d036996ccb422964135650d4416081474c

[nhiroki, 2017-04-26 09:19:51]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

BUG=627945
==========

[nhiroki, 2017-04-26 10:33:34]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec.
When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes the request id mechanism in MainThreadWorklet and
WorkletObjectProxy using the pending tasks struct.

BUG=627945
==========

[nhiroki, 2017-04-26 10:33:40]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 10:33:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-26 10:35:02]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec.
When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes the request id mechanism in MainThreadWorklet and
WorkletObjectProxy using the pending tasks struct.

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes the request id mechanism in MainThreadWorklet and
WorkletObjectProxy using the pending tasks struct.

BUG=627945
==========

[nhiroki, 2017-04-26 10:35:58]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 10:36:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-26 10:36:05]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-04-26 10:37:24]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes the request id mechanism in MainThreadWorklet and
WorkletObjectProxy using the pending tasks struct.

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

[nhiroki, 2017-04-26 10:37:32]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-04-26 10:37:44]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2017-04-26 10:49:37]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

When Worklet::addModule() is called, multiple WorkletGlobalScopes associated
with the Worklet start module loading. The struct is used as a kind of barrier
closure: the struct owns a promise resolver and resolves a promise when all
module loading are completed or rejects it when one of them is failed.

The CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

The CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

[nhiroki, 2017-04-26 10:55:18]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 10:55:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-26 10:56:23]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2017-04-26 10:57:26]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

The CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

[nhiroki, 2017-04-26 10:58:52]

nhiroki@chromium.org changed reviewers:
+ ikilpatrick@chromium.org, kouhei@chromium.org

[nhiroki, 2017-04-26 10:58:53]

Hi, can you review this? Thanks :)

https://codereview.chromium.org/2839123003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp (right):

https://codereview.chromium.org/2839123003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:44: // Step 11:
"Let pendingTaskStruct be a new pending tasks struct with counter
FYI: Other step comments will be added by
https://codereview.chromium.org/2840523002/

[commit-bot: I haz the power, 2017-04-26 11:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 11:58:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-04-27 00:06:50]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 00:07:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-27 00:34:52]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 00:35:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 03:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 03:02:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kouhei (in TOK), 2017-04-27 10:05:33]

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp (right):

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:41: // Step 11:
"Let pendingTaskStruct be a new pending tasks struct with counter
Add context link https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:45: const int
number_of_global_scopes = 1;
constexpr?

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:54: //
TODO(nhiroki): Pass the remaining parameters (e.g., credentialOptions).
Add a note about skipping "queue a task". TODO or justification.

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:93: if
(it == loader_map_.end())
when is it == end?

[nhiroki, 2017-04-28 02:32:13]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:33:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-28 04:41:14]

Thank you!

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp (right):

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:41: // Step 11:
"Let pendingTaskStruct be a new pending tasks struct with counter
On 2017/04/27 10:05:33, kouhei wrote:
> Add context link
https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule 

Done.

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:45: const int
number_of_global_scopes = 1;
On 2017/04/27 10:05:33, kouhei wrote:
> constexpr?

Done.

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:54: //
TODO(nhiroki): Pass the remaining parameters (e.g., credentialOptions).
On 2017/04/27 10:05:33, kouhei wrote:
> Add a note about skipping "queue a task". TODO or justification.

Done.

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2839123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:93: if
(it == loader_map_.end())
On 2017/04/27 10:05:33, kouhei wrote:
> when is it == end?

Yeah, this never happens. Replaced this with DCHECK.

By the way, I noticed NotifyWorkletScriptLoadingFinished() is called from
TeminateWorkletGlobalScope() via WorkletScriptLoader::Cancel(), and it causes
iterator invalidation. To avoid it, I also changed TeminateWorkletGlobalScope().

[commit-bot: I haz the power, 2017-04-28 05:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:01:14]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2017-04-28 05:11:59]

lgtm

[nhiroki, 2017-04-28 05:14:42]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2017-04-28 05:14:43]

+haraken@, can you review modules/? This just removes an unused argument.
Thanks!

[haraken, 2017-04-28 05:39:21]

modules/ LGTM

[nhiroki, 2017-04-28 05:40:08]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:40:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:46:43]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493358008047210,
"parent_rev": "fca892fe54b316243806c3b1cfc6cad5e23ae098", "commit_rev":
"322942d036996ccb422964135650d4416081474c"}

[commit-bot: I haz the power, 2017-04-28 05:46:53]

Description was changed from

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945
==========

to

==========
Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945

Review-Url: https://codereview.chromium.org/2839123003
Cr-Commit-Position: refs/heads/master@{#467908}
Committed:
https://chromium.googlesource.com/chromium/src/+/322942d036996ccb422964135650...
==========

[commit-bot: I haz the power, 2017-04-28 05:46:54]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/322942d036996ccb422964135650...