third_party/WebKit/Source/core/workers/ThreadedWorklet.h - Issue 2839123003: Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorklet.h

Issue 2839123003: Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec (Closed)

Patch Set: address review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/ThreadedWorklet.h

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorklet.h b/third_party/WebKit/Source/core/workers/ThreadedWorklet.h

index 4c4d92d1252ce877dbf5e53a1e6dc810da92967b..c238fbf2d12f3efd6fc69ab936c4b6ce4bf54565 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorklet.h

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorklet.h

@@ -34,7 +34,7 @@ class CORE_EXPORT ThreadedWorklet : public Worklet,

virtual bool IsInitialized() const = 0;

// Worklet

- ScriptPromise addModule(ScriptState*, const String& url) final;

+ ScriptPromise addModule(ScriptState*, const String& module_url) final;

// WorkletScriptLoader::Client

void NotifyWorkletScriptLoadingFinished(WorkletScriptLoader*,