Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorklet.h

Issue 2839123003: Worklet: Introduce "pending tasks struct" concept defined in the Worklet spec (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/MainThreadWorklet.h
diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorklet.h b/third_party/WebKit/Source/core/workers/MainThreadWorklet.h
index 07845f3601f7382c8013ed505257f37221a63060..de5853b093bb05442a58c6c296fec91e41c83e93 100644
--- a/third_party/WebKit/Source/core/workers/MainThreadWorklet.h
+++ b/third_party/WebKit/Source/core/workers/MainThreadWorklet.h
@@ -9,7 +9,6 @@
#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "core/CoreExport.h"
-#include "core/workers/WorkletObjectProxy.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -20,8 +19,7 @@ class LocalFrame;
// TODO(nhiroki): This is a temporary class to support module loading for main
// thread worklets. This and ThreadedWorklet will be merged into the base
// Worklet class once threaded worklets are ready to use module loading.
-class CORE_EXPORT MainThreadWorklet : public Worklet,
- public WorkletObjectProxy {
+class CORE_EXPORT MainThreadWorklet : public Worklet {
USING_GARBAGE_COLLECTED_MIXIN(MainThreadWorklet);
WTF_MAKE_NONCOPYABLE(MainThreadWorklet);
@@ -29,22 +27,15 @@ class CORE_EXPORT MainThreadWorklet : public Worklet,
virtual ~MainThreadWorklet() = default;
// Worklet
- ScriptPromise addModule(ScriptState*, const String& url) final;
+ ScriptPromise addModule(ScriptState*, const String& module_url) final;
// ContextLifecycleObserver
void ContextDestroyed(ExecutionContext*) final;
- // WorkletObjectProxy
- void DidFetchAndInvokeScript(int32_t request_id, bool success) final;
-
DECLARE_VIRTUAL_TRACE();
protected:
explicit MainThreadWorklet(LocalFrame*);
-
- private:
- HeapHashMap<int32_t /* request_id */, Member<ScriptPromiseResolver>>
- resolver_map_;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/workers/BUILD.gn ('k') | third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698