🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- Still trying to figure out how to test this.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223, 712836, 712833
Review-Url: https://codereview.chromium.org/2838833002
Cr-Commit-Position: refs/heads/master@{#467766}
Committed: https://chromium.googlesource.com/chromium/src/+/42776f8a5b7e07ce63442004737150495eed0db0
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 8 months ago
(2017-04-25 06:15:12 UTC)
#1
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests are forthcoming.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests are forthcoming.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
Cleaned this up a bit. WDYT? I'm still working on tests but it'd be good ...
3 years, 8 months ago
(2017-04-25 06:16:47 UTC)
#3
Cleaned this up a bit. WDYT? I'm still working on tests but it'd be good to
get some general feedback before plowing ahead.
gone
I'm having trouble hooking this up to the SearchActivity properly without dealing with race conditions. ...
3 years, 8 months ago
(2017-04-25 21:04:58 UTC)
#4
I'm having trouble hooking this up to the SearchActivity properly without
dealing with race conditions. I'm going to prepare another CL that yanks out
anything involving that, so please hold off for now.
gone
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 8 months ago
(2017-04-25 21:38:52 UTC)
#5
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests are forthcoming.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests will come in the next CL.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
gone
I think I got a handle on it. PTAL. Testing this manually is driving me ...
3 years, 8 months ago
(2017-04-25 21:40:19 UTC)
#6
I think I got a handle on it. PTAL. Testing this manually is driving me nuts
so I'll be working on SearchActivity tests next. Those would include tests for
clicking on things in the Dialog, as well.
gone
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
3 years, 8 months ago
(2017-04-25 21:46:47 UTC)
#7
3 years, 8 months ago
(2017-04-25 23:22:05 UTC)
#10
Dry run: This issue passed the CQ dry run.
gone
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 8 months ago
(2017-04-26 05:45:50 UTC)
#11
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests will come in the next CL.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests will come in the next CL:
https://chromiumcodereview.appspot.com/2842943002/
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
gone
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 8 months ago
(2017-04-26 05:47:24 UTC)
#12
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests will come in the next CL:
https://chromiumcodereview.appspot.com/2842943002/
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Basic tests will come in the next CL, with more to follow afterward:
https://chromiumcodereview.appspot.com/2842943002/
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
gone
https://codereview.chromium.org/2838833002/diff/180001/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java File chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java (right): https://codereview.chromium.org/2838833002/diff/180001/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java#newcode24 chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java:24: * specific behaviors (see go/snowflake-dialogs for details): Clarified why ...
3 years, 8 months ago
(2017-04-26 05:52:36 UTC)
#13
Something about the refactoring I did between patch sets 11 through 13 seems to have ...
3 years, 8 months ago
(2017-04-26 19:00:30 UTC)
#16
Something about the refactoring I did between patch sets 11 through 13 seems to
have fixed the threading issue I was seeing, so this should be reviewable again
:/ Sorry for the churn.
gone
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 8 months ago
(2017-04-26 19:27:27 UTC)
#17
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
General:
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Basic tests will come in the next CL, with more to follow afterward:
https://chromiumcodereview.appspot.com/2842943002/
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- Still trying to figure out how to test this.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
gone
I had to yank out the PromoDialogLayout logic. This CL was sucking in a lot ...
3 years, 8 months ago
(2017-04-26 19:28:35 UTC)
#18
I had to yank out the PromoDialogLayout logic. This CL was sucking in a lot of
Activity changes becoming an easy target for reverting everything at once. PTAL
gone
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
3 years, 8 months ago
(2017-04-26 19:30:31 UTC)
#19
Comments from a few versions ago...hopefully not entirely invalid anymore https://codereview.chromium.org/2838833002/diff/200001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java (right): https://codereview.chromium.org/2838833002/diff/200001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java#newcode380 ...
3 years, 8 months ago
(2017-04-26 20:21:53 UTC)
#22
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/280655)
3 years, 8 months ago
(2017-04-27 02:54:15 UTC)
#33
3 years, 8 months ago
(2017-04-27 04:59:34 UTC)
#37
Dry run: This issue passed the CQ dry run.
Ted C
https://codereview.chromium.org/2838833002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java File chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java (right): https://codereview.chromium.org/2838833002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java#newcode31 chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java:31: private final int mDialogType; I think my comment from ...
3 years, 7 months ago
(2017-04-27 16:40:46 UTC)
#38
Added a TODO for yusuf there. https://codereview.chromium.org/2838833002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java File chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java (right): https://codereview.chromium.org/2838833002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java#newcode31 chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java:31: private final int ...
3 years, 7 months ago
(2017-04-27 17:48:52 UTC)
#39
CQ is committing da patch. Bot data: {"patchset_id": 400001, "attempt_start_ts": 1493317802152080, "parent_rev": "4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf", "commit_rev": "42776f8a5b7e07ce63442004737150495eed0db0"}
3 years, 7 months ago
(2017-04-27 20:28:20 UTC)
#50
CQ is committing da patch.
Bot data: {"patchset_id": 400001, "attempt_start_ts": 1493317802152080,
"parent_rev": "4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf", "commit_rev":
"42776f8a5b7e07ce63442004737150495eed0db0"}
commit-bot: I haz the power
Description was changed from ========== 🔍 Introduce default search engine dialog Add a dialog that ...
3 years, 7 months ago
(2017-04-27 20:28:30 UTC)
#51
Message was sent while issue was closed.
Description was changed from
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- Still trying to figure out how to test this.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
==========
to
==========
🔍 Introduce default search engine dialog
Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.
DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine. This
dialog only shows up for the "existing user" case and (currently) randomizes
the search engines available as defined in the TemplateUrlService.
* Add the ability to show the DefaultSearchEnginePromoDialog from the
LocaleManager. It currently never fires because the logic hasn't landed, but
it is triggered from ChromeTabbedActivity and SearchActivity.
Things to do:
- Still trying to figure out how to test this.
Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223,712836,712833
Review-Url: https://codereview.chromium.org/2838833002
Cr-Commit-Position: refs/heads/master@{#467766}
Committed:
https://chromium.googlesource.com/chromium/src/+/42776f8a5b7e07ce634420047371...
==========
commit-bot: I haz the power
Committed patchset #21 (id:400001) as https://chromium.googlesource.com/chromium/src/+/42776f8a5b7e07ce63442004737150495eed0db0
3 years, 7 months ago
(2017-04-27 20:28:31 UTC)
#52
Issue 2838833002: 🔍 Introduce default search engine dialog
(Closed)
Created 3 years, 8 months ago by gone
Modified 3 years, 7 months ago
Reviewers: Ted C, Yusuf
Base URL:
Comments: 33