🔍 Introduce default search engine dialog

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Paint;
+import android.support.annotation.Nullable;
 import android.support.v7.widget.SwitchCompat;
 import android.text.method.LinkMovementMethod;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ArrayAdapter;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.RadioButton;
 import android.widget.RadioGroup;
@@ skipping 17 matching lines @@
  *
  * Manually specified margins on the children managed by this layout are EXPLICITLY ignored to
  * enforce a uniform margin between controls across all InfoBar types.  Do NOT circumvent this
  * restriction with creative layout definitions.  If the layout algorithm doesn't work for your new
  * InfoBar, convince Chrome for Android's UX team to amend the master spec and then change the
  * layout algorithm to match.
  *
  * TODO(dfalcantara): The line spacing multiplier is applied to all lines in JB & KK, even if the
  *                    TextView has only one line.  This throws off vertical alignment.  Find a
  *                    solution that hopefully doesn't involve subclassing the TextView.
+ *
+ * TODO(dfalcantara): Move this to a more general location.
  */
 public final class InfoBarControlLayout extends ViewGroup {
+    public static final int INVALID_INDEX = -1;
+
     /**
      * ArrayAdapter that automatically determines what size make its Views to accommodate all of
      * its potential values.
+     * @param <T> Type of object that the ArrayAdapter stores.
      */
     public static final class InfoBarArrayAdapter<T> extends ArrayAdapter<T> {
         private final String mLabel;
         private int mMinWidthRequiredForValues;
 
         public InfoBarArrayAdapter(Context context, String label) {
             super(context, R.layout.infobar_control_spinner_drop_down);
             mLabel = label;
         }
 
@@ skipping 292 matching lines @@
 
     /**
      * Creates a set of standard radio buttons and adds it to the layout.
      *
      * -------------------------------------------------
      * | O | MESSAGE #1                                |
      * | O | MESSAGE #N                                |
      * -------------------------------------------------
      *
      * @param messages      Messages to display for the options.
+     * @param tags          Optional list of tags to attach to the buttons.
      * @param selectedIndex Which index to mark as being selected.
      */
-    public RadioGroup addRadioButtons(List<CharSequence> messages, int selectedIndex) {
+    public RadioGroup addRadioButtons(
+            List<CharSequence> messages, @Nullable List<?> tags, int selectedIndex) {
         ControlLayoutParams params = new ControlLayoutParams();
         params.mMustBeFullWidth = true;
 
         RadioGroup radioLayout = new RadioGroup(getContext());
         addView(radioLayout, params);
 

[Ted C, 2017/04/26 20:21:52]

maybe add

if (tags != null) assert tags.size() == messages.size();

[gone, 2017/04/26 21:45:15]

Done on the forked copy.

         for (int i = 0; i < messages.size(); i++) {
             RadioButton button =
                     (RadioButton) LayoutInflater.from(getContext())
                             .inflate(R.layout.infobar_control_radio, radioLayout, false);
             button.setText(messages.get(i));
+            if (tags != null) button.setTag(tags.get(i));
             button.setChecked(i == selectedIndex);
             radioLayout.addView(button);
 
             // Add margins between each of the radio buttons.
             if (i < messages.size() - 1) {
                 ((MarginLayoutParams) button.getLayoutParams()).bottomMargin = mMarginBetweenRows;
             }
         }
 
         return radioLayout;
@@ skipping 63 matching lines @@
 
     /**
      * @return The {@link ControlLayoutParams} for the given child.
      */
     @VisibleForTesting
     static ControlLayoutParams getControlLayoutParams(View child) {
         return (ControlLayoutParams) child.getLayoutParams();
     }
 
 }