🔍 Introduce default search engine dialog

chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.searchwidget;
 
 import android.annotation.SuppressLint;
 import android.app.PendingIntent;
 import android.appwidget.AppWidgetManager;
 import android.appwidget.AppWidgetProvider;
@@ skipping 10 matching lines @@
 import android.widget.RemoteViews;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;
+import org.chromium.chrome.browser.omnibox.LocationBarLayout;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService.LoadListener;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrlServiceObserver;
 import org.chromium.chrome.browser.util.IntentUtils;
 
 /**
  * Widget that lets the user search using their default search engine.
  *
  * Because this is a BroadcastReceiver, it dies immediately after it runs.  A new one is created
  * for each new broadcast.
@@ skipping 75 matching lines @@
     static final String PREF_SEARCH_ENGINE_SHORTNAME =
             "org.chromium.chrome.browser.searchwidget.SEARCH_ENGINE_SHORTNAME";
 
     /** Number of consecutive crashes this widget will absorb before giving up. */
     private static final int CRASH_LIMIT = 3;
 
     private static final String TAG = "searchwidget";
     private static final Object DELEGATE_LOCK = new Object();
     private static final Object OBSERVER_LOCK = new Object();
 
+    /** The default search engine's root URL. */
+    private static String sDefaultSearchEngineUrl;
+
     private static SearchWidgetTemplateUrlServiceObserver sObserver;
     private static SearchWidgetProviderDelegate sDelegate;
 
     /**
      * Creates the singleton instance of the observer that will monitor for search engine changes.
      * The native library and the browser process must have been fully loaded before calling this.
      */
     public static void initialize() {
         ThreadUtils.assertOnUiThread();
         assert LibraryLoader.isInitialized();
@@ skipping 148 matching lines @@
     /** Attempts to update the cached search engine name. */
     public static void updateCachedEngineName() {
         ThreadUtils.assertOnUiThread();
         if (!LibraryLoader.isInitialized()) return;
 
         // Getting an instance of the TemplateUrlService requires that the native library be
         // loaded, but the TemplateUrlService also itself needs to be initialized.
         TemplateUrlService service = TemplateUrlService.getInstance();
         if (!service.isLoaded()) return;
 
+        // Update the URL that we show for zero-suggest.
+        String searchEngineUrl = service.getSearchEngineUrlFromTemplateUrl(
+                service.getDefaultSearchEngineTemplateUrl().getKeyword());
+        sDefaultSearchEngineUrl =
+                LocationBarLayout.splitPathFromUrlDisplayText(searchEngineUrl).first;
+
         updateCachedEngineName(service.getDefaultSearchEngineTemplateUrl().getShortName());
     }
 
     /**
      * Updates the name of the user's default search engine that is cached in SharedPreferences.
      * Caching it in SharedPreferences prevents us from having to load the native library and the
      * TemplateUrlService whenever the widget is updated.
      */
     static void updateCachedEngineName(String engineName) {
         SharedPreferences prefs = getDelegate().getSharedPreferences();
@@ skipping 72 matching lines @@
                 getDelegate().getContext(), null, false);
         return freIntent == null;
     }
 
     /** Sets an {@link SearchWidgetProviderDelegate} to interact with. */
     @VisibleForTesting
     static void setDelegateForTest(SearchWidgetProviderDelegate delegate) {
         assert sDelegate == null;
         sDelegate = delegate;
     }
+
+    /** See {@link #sDefaultSearchEngineUrl}. */
+    static String getDefaultSearchEngineUrl() {
+        return sDefaultSearchEngineUrl;

[Ted C, 2017/04/27 16:40:46]

can/should this ever be null?  Wondering if we should assert that
updateCachedEngineName was called first (even if this doesn't change the
existing behavior we should add checks to ensure that was correct).

[gone, 2017/04/27 17:48:52]

This was added by Yusuf for showing the engine's URL as an autocomplete
suggestion, IIRC.  I don't think it's safe to assert null here, but if it's null
nothing seems to break.

+    }
 }