Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

Issue 2838833002: 🔍 Introduce default search engine dialog (Closed)
Patch Set: COmments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
index 288e5bf35c25a9c619180b4b9cbd46fe58fbc7ea..9b8c634d1ad560c5877bb505676ec16915e38d3c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
@@ -17,6 +17,7 @@ import android.text.style.StyleSpan;
import android.view.View;
import android.widget.TextView;
+import org.chromium.base.Callback;
import org.chromium.base.ContextUtils;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
@@ -47,7 +48,7 @@ public class SogouPromoDialog extends PromoDialog {
private static final int CHOICE_ENUM_COUNT = 4;
/** Run when the dialog is dismissed. */
- private final Runnable mOnDismissedRunnable;
+ private final Callback<Boolean> mOnDismissedCallback;
private final LocaleManager mLocaleManager;
private final ClickableSpan mSpan = new NoUnderlineClickableSpan() {
@@ -68,12 +69,12 @@ public class SogouPromoDialog extends PromoDialog {
* Creates an instance of the dialog.
*/
public SogouPromoDialog(
- Context context, LocaleManager localeManager, @Nullable Runnable onDismissed) {
+ Context context, LocaleManager localeManager, @Nullable Callback<Boolean> onDismissed) {
super(context);
mLocaleManager = localeManager;
setOnDismissListener(this);
setCanceledOnTouchOutside(false);
- mOnDismissedRunnable = onDismissed;
+ mOnDismissedCallback = onDismissed;
}
@Override
@@ -150,6 +151,6 @@ public class SogouPromoDialog extends PromoDialog {
RecordHistogram.recordEnumeratedHistogram(
"SpecialLocale.PromotionDialog", mChoice, CHOICE_ENUM_COUNT);
- if (mOnDismissedRunnable != null) mOnDismissedRunnable.run();
+ if (mOnDismissedCallback != null) mOnDismissedCallback.onResult(true);
}
}

Powered by Google App Engine
This is Rietveld 408576698