Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after.

Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after.

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2838293002
Cr-Commit-Position: refs/heads/master@{#467370}
Committed: https://chromium.googlesource.com/chromium/src/+/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162

[jam, 2017-04-26 00:28:06]

Description was changed from

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not afterfdf

BUG=
==========

to

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not afterfdf

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-04-26 00:28:09]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:28:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:41:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-04-26 03:52:11]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 03:52:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 04:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 04:02:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-04-26 04:04:35]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 04:04:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 04:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 04:34:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-04-26 06:18:32]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 06:18:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 06:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 06:39:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-04-26 14:51:27]

Patchset #3 (id:40001) has been deleted

[jam, 2017-04-26 14:51:35]

Patchset #2 (id:20001) has been deleted

[jam, 2017-04-26 14:51:42]

Patchset #1 (id:1) has been deleted

[jam, 2017-04-26 14:51:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-04-26 14:51:59]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-04-26 14:52:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 15:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 15:43:53]

Dry run: This issue passed the CQ dry run.

[jam, 2017-04-26 16:11:48]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[jam, 2017-04-26 16:29:28]

Description was changed from

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not afterfdf

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not afterfdf

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-04-26 16:29:39]

Description was changed from

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not afterfdf

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not after.

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[scottmg, 2017-04-26 16:38:44]

Could you have a DCHECK somewhere that checks that someone doesn't AddRule()
later?

lgtm

[jam, 2017-04-26 17:36:01]

On 2017/04/26 16:38:44, scottmg wrote:
> Could you have a DCHECK somewhere that checks that someone doesn't AddRule()
> later?
> 
> lgtm

Yep that'll happen in a followup as I have one harder case left :)

[jam, 2017-04-26 17:36:07]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:36:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:49:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493228167848030,
"parent_rev": "bd8123c6dd3eee758fa21adaeb91bb8e0c988b4e", "commit_rev":
"8f34ea7b0b5524e427fbadad6e0cb06e8ff59162"}

[commit-bot: I haz the power, 2017-04-26 17:49:09]

Description was changed from

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not after.

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Ensure all content_browsertests call the host resolver in SetUpOnMainThread and
not after.

BUG=713847
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2838293002
Cr-Commit-Position: refs/heads/master@{#467370}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f34ea7b0b5524e427fbadad6e0c...
==========

[commit-bot: I haz the power, 2017-04-26 17:49:11]

Committed patchset #1 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8f34ea7b0b5524e427fbadad6e0c...