Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after.

content/browser/devtools/site_per_process_devtools_browsertest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/site_per_process_browsertest.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "content/shell/browser/shell_download_manager_delegate.h"
 #include "content/test/content_browser_test_utils_internal.h"
 #include "net/dns/mock_host_resolver.h"
 
 namespace content {
 
-class SitePerProcessDevToolsBrowserTest
-    : public SitePerProcessBrowserTest {
+class SitePerProcessDevToolsBrowserTest : public SitePerProcessBrowserTest {
  public:
   SitePerProcessDevToolsBrowserTest() {}
+  void SetUpOnMainThread() override {
+    host_resolver()->AddRule("*", "127.0.0.1");
+    SitePerProcessBrowserTest::SetUpOnMainThread();
+  }
 };
 
 class TestClient: public DevToolsAgentHostClient {
  public:
   TestClient() : closed_(false), waiting_for_reply_(false) {}
   ~TestClient() override {}
 
   bool closed() { return closed_; }
 
   void DispatchProtocolMessage(
@@ skipping 23 matching lines @@
 
 // Fails on Android, http://crbug.com/464993.
 #if defined(OS_ANDROID)
 #define MAYBE_CrossSiteIframeAgentHost DISABLED_CrossSiteIframeAgentHost
 #else
 #define MAYBE_CrossSiteIframeAgentHost CrossSiteIframeAgentHost
 #endif
 IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
                        MAYBE_CrossSiteIframeAgentHost) {
   DevToolsAgentHost::List list;
-  host_resolver()->AddRule("*", "127.0.0.1");
   GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   // It is safe to obtain the root frame tree node here, as it doesn't change.
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
 
   list = DevToolsAgentHost::GetOrCreateAll();
   EXPECT_EQ(1U, list.size());
@@ skipping 51 matching lines @@
   EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec());
   EXPECT_TRUE(child_client.closed());
   child_host->DetachClient(&child_client);
   child_host = nullptr;
   EXPECT_FALSE(parent_client.closed());
   parent_host->DetachClient(&parent_client);
   parent_host = nullptr;
 }
 
 IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest, AgentHostForFrames) {
-  host_resolver()->AddRule("*", "127.0.0.1");
   GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   scoped_refptr<DevToolsAgentHost> page_agent =
       DevToolsAgentHost::GetOrCreateFor(shell()->web_contents());
 
   // It is safe to obtain the root frame tree node here, as it doesn't change.
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
@@ skipping 20 matching lines @@
 
   child_frame_agent =
       DevToolsAgentHost::GetOrCreateFor(child->current_frame_host());
   EXPECT_NE(page_agent.get(), child_frame_agent.get());
   EXPECT_EQ(child_frame_agent->GetParentId(), page_agent->GetId());
   EXPECT_NE(child_frame_agent->GetId(), page_agent->GetId());
 }
 
 IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
     AgentHostForPageEqualsOneForMainFrame) {
-  host_resolver()->AddRule("*", "127.0.0.1");
   GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   // It is safe to obtain the root frame tree node here, as it doesn't change.
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
   FrameTreeNode* child = root->child_at(0);
 
   // Load cross-site page into iframe.
@@ skipping 60 matching lines @@
   ASSERT_TRUE(NavigateToURLAndExpectNoCommit(shell(), cross_site_url));
 
   // Check that client is still responding after not committed navigation
   // is finished.
   agent->DispatchProtocolMessage(&client, message);
   client.WaitForReply();
   ASSERT_TRUE(agent->DetachClient(&client));
 }
 
 }  // namespace content