Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: content/browser/loader/resource_dispatcher_host_browsertest.cc

Issue 2838293002: Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_browsertest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_browsertest.cc b/content/browser/loader/resource_dispatcher_host_browsertest.cc
index d330139ebcabc3348245d0ac980146990661e86d..806df8c31911fb8371d8d687d655d99b13bd1dc9 100644
--- a/content/browser/loader/resource_dispatcher_host_browsertest.cc
+++ b/content/browser/loader/resource_dispatcher_host_browsertest.cc
@@ -873,6 +873,7 @@ class RequestDataResourceDispatcherHostBrowserTest : public ContentBrowserTest {
content::BrowserThread::IO, FROM_HERE,
base::Bind(&RequestDataResourceDispatcherHostDelegate::SetDelegate,
base::Unretained(delegate_.get())));
+ host_resolver()->AddRule("*", "127.0.0.1");
}
protected:
@@ -912,7 +913,6 @@ IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest, Basic) {
IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
BasicCrossSite) {
- host_resolver()->AddRule("*", "127.0.0.1");
GURL top_url(embedded_test_server()->GetURL(
"a.com", "/nested_page_with_subresources.html"));
GURL nested_url(embedded_test_server()->GetURL(
@@ -1099,7 +1099,6 @@ IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
CrossOriginNested) {
- host_resolver()->AddRule("*", "127.0.0.1");
GURL top_url(embedded_test_server()->GetURL(
"a.com", "/cross_site_iframe_factory.html?a(b)"));
GURL top_js_url(

Powered by Google App Engine
This is Rietveld 408576698