Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 2838293002: Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/site_per_process_devtools_browsertest.cc
diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc
index e119d8022a4974a6d4efb57dfb1a57a753c11c6a..62817ef0caeba07f495bd4c37bd5720de01c98cb 100644
--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc
+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc
@@ -19,10 +19,13 @@
namespace content {
-class SitePerProcessDevToolsBrowserTest
- : public SitePerProcessBrowserTest {
+class SitePerProcessDevToolsBrowserTest : public SitePerProcessBrowserTest {
public:
SitePerProcessDevToolsBrowserTest() {}
+ void SetUpOnMainThread() override {
+ host_resolver()->AddRule("*", "127.0.0.1");
+ SitePerProcessBrowserTest::SetUpOnMainThread();
+ }
};
class TestClient: public DevToolsAgentHostClient {
@@ -66,7 +69,6 @@ class TestClient: public DevToolsAgentHostClient {
IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
MAYBE_CrossSiteIframeAgentHost) {
DevToolsAgentHost::List list;
- host_resolver()->AddRule("*", "127.0.0.1");
GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
NavigateToURL(shell(), main_url);
@@ -138,7 +140,6 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
}
IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest, AgentHostForFrames) {
- host_resolver()->AddRule("*", "127.0.0.1");
GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
NavigateToURL(shell(), main_url);
@@ -179,7 +180,6 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest, AgentHostForFrames) {
IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
AgentHostForPageEqualsOneForMainFrame) {
- host_resolver()->AddRule("*", "127.0.0.1");
GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
NavigateToURL(shell(), main_url);
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698