Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2838123002: Count element name validity per DOM versus HTML parsing. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
CC:
domenic, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sof, Srirama, szager+layoutwatch_chromium.org, webcomponents-bugzilla_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Count element name validity per DOM versus HTML parsing. DOM uses the XML "Name" production for tag name validity, whereas the HTML parser does something different. This creates edge cases where some elements can only be created by createElement, like <:foo>, and some can only be created by the HTML parser, like <foo">. This adds a use counter to count how often pages use createElement, etc. with tag names that are valid in one system but not the other to determine whether it is practical for DOM to use the same rules as HTML for tag names. BUG=648179 Review-Url: https://codereview.chromium.org/2838123002 Cr-Commit-Position: refs/heads/master@{#467219} Committed: https://chromium.googlesource.com/chromium/src/+/cb56b4ff751b3fef6ada2ae547a2c374caca8361

Patch Set 1 #

Patch Set 2 : Do not need the attribute counting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -43 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/name-validity-usecounter.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 3 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 7 chunks +60 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeTest.cpp View 5 chunks +18 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 8 months ago (2017-04-25 08:49:43 UTC) #6
tkent
lgtm
3 years, 8 months ago (2017-04-25 09:14:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838123002/20001
3 years, 8 months ago (2017-04-26 00:27:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/420377)
3 years, 8 months ago (2017-04-26 00:38:25 UTC) #13
dominicc (has gone to gerrit)
+erickwilligers for histograms.xml, PTAL
3 years, 8 months ago (2017-04-26 02:20:23 UTC) #15
haraken
On 2017/04/26 02:20:23, dominicc wrote: > +erickwilligers for histograms.xml, PTAL LGTM
3 years, 8 months ago (2017-04-26 02:20:52 UTC) #16
Eric Willigers
lgtm
3 years, 8 months ago (2017-04-26 02:47:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838123002/20001
3 years, 8 months ago (2017-04-26 03:00:50 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 03:08:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb56b4ff751b3fef6ada2ae547a2...

Powered by Google App Engine
This is Rietveld 408576698