Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2838123002: Count element name validity per DOM versus HTML parsing. (Closed)
Patch Set: Do not need the attribute counting. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
index 41180201acb35f6f7e35d417ae5e1fa3fb7b685f..d79cf3099ad30de86952995d81a7fb755e2a4c13 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
@@ -30,7 +30,7 @@ class CustomElementUpgradeSorterTest : public ::testing::Test {
Element* CreateElementWithId(const char* local_name, const char* id) {
NonThrowableExceptionState no_exceptions;
Element* element = GetDocument()->createElement(
- local_name, StringOrDictionary(), no_exceptions);
+ nullptr, local_name, StringOrDictionary(), no_exceptions);
element->setAttribute(HTMLNames::idAttr, id);
return element;
}
@@ -55,8 +55,8 @@ class CustomElementUpgradeSorterTest : public ::testing::Test {
TEST_F(CustomElementUpgradeSorterTest, inOtherDocument_notInSet) {
NonThrowableExceptionState no_exceptions;
- Element* element =
- GetDocument()->createElement("a-a", StringOrDictionary(), no_exceptions);
+ Element* element = GetDocument()->createElement(
+ nullptr, "a-a", StringOrDictionary(), no_exceptions);
Document* other_document = HTMLDocument::Create();
other_document->AppendChild(element);
@@ -74,8 +74,8 @@ TEST_F(CustomElementUpgradeSorterTest, inOtherDocument_notInSet) {
TEST_F(CustomElementUpgradeSorterTest, oneCandidate) {
NonThrowableExceptionState no_exceptions;
- Element* element =
- GetDocument()->createElement("a-a", StringOrDictionary(), no_exceptions);
+ Element* element = GetDocument()->createElement(
+ nullptr, "a-a", StringOrDictionary(), no_exceptions);
GetDocument()->documentElement()->AppendChild(element);
CustomElementUpgradeSorter sorter;

Powered by Google App Engine
This is Rietveld 408576698