third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp - Issue 2838123002: Count element name validity per DOM versus HTML parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

Issue 2838123002: Count element name validity per DOM versus HTML parsing. (Closed)

Patch Set: Do not need the attribute counting. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/name-validity-usecounter.html ('k') | third_party/WebKit/Source/core/dom/DOMImplementation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

index 3564c21d31dc671633140390734dc89fb720293e..f2643357772af624a5cb2e0e6302256bc1814deb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

@@ -343,7 +343,7 @@ static void ConstructCustomElement(

"CustomElement");

V0CustomElementProcessingStack::CallbackDeliveryScope delivery_scope;

Element* element = document->createElementNS(

- namespace_uri, tag_name,

+ nullptr, namespace_uri, tag_name,

StringOrDictionary::fromString(maybe_type->IsNull() ? g_null_atom : type),

exception_state);

if (element) {