third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h - Issue 2838123002: Count element name validity per DOM versus HTML parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

Issue 2838123002: Count element name validity per DOM versus HTML parsing. (Closed)

Patch Set: Do not need the attribute counting. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

index f710de0b9183ce631156b6a27e521ad933b79aee..04ef2808de8af5d37a47cd9d69b9495fbdaf303e 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

@@ -123,8 +123,8 @@ class CreateElement {

if (!document)

document = HTMLDocument::Create();

NonThrowableExceptionState no_exceptions;

- Element* element =

- document->createElementNS(namespace_uri_, local_name_, no_exceptions);

+ Element* element = document->createElementNS(nullptr, namespace_uri_,

+ local_name_, no_exceptions);

for (const auto& attribute : attributes_)

element->setAttribute(attribute.first, attribute.second);

return element;