Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2836473002: Reland of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (Closed)

Created:
3 years, 8 months ago by nhiroki
Modified:
3 years, 8 months ago
Reviewers:
yuryu, kinuko, tzik
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (patchset #1 id:1 of https://codereview.chromium.org/2833673002/ ) Reason for revert: The CL that this CL depends on was relanded: https://codereview.chromium.org/2832763002/ Original issue's description: > Revert of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (patchset #2 id:20001 of https://codereview.chromium.org/2818073002/ ) > > Reason for revert: > [1] that this CL depends on needs to be reverted: > https://codereview.chromium.org/2831843002/ > > Original issue's description: > > Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() > > > > As implementation comments in MessagePort::messageAvailable(), it can be called > > from another thread and should not call non-thread-functions. However, the > > current implementation wrongly calls ContextLifecycleObserver's > > GetExecutionContext() that is not a thread-safe function to post a task to the > > context thread. > > > > To avoid that, this CL replaces ExecutionContext::PostTask() with > > WebTaskRunner::PostTask(). The task runner is captured in the ctor of > > MessagePort called on the context thread. > > > > BUG=694925 > > > > Review-Url: https://codereview.chromium.org/2818073002 > > Cr-Commit-Position: refs/heads/master@{#465886} > > Committed: https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d0e45df1e8325 > > TBR=tzik@chromium.org,yuryu@chromium.org,kinuko@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=694925 > > Review-Url: https://codereview.chromium.org/2833673002 > Cr-Commit-Position: refs/heads/master@{#465890} > Committed: https://chromium.googlesource.com/chromium/src/+/7cbe41ace5629ba6b9ec5502803f02fb2f09b0fd TBR=tzik@chromium.org,yuryu@chromium.org,kinuko@chromium.org BUG=694925 Review-Url: https://codereview.chromium.org/2836473002 Cr-Commit-Position: refs/heads/master@{#466223} Committed: https://chromium.googlesource.com/chromium/src/+/90cbb1bd3931fb8ee58c729bbbcdb32f4915dd1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M third_party/WebKit/Source/core/dom/MessagePort.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 3 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nhiroki
Created Reland of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()
3 years, 8 months ago (2017-04-20 23:01:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836473002/1
3 years, 8 months ago (2017-04-20 23:03:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/410132)
3 years, 8 months ago (2017-04-20 23:05:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836473002/1
3 years, 8 months ago (2017-04-20 23:53:25 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 02:00:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90cbb1bd3931fb8ee58c729bbbcd...

Powered by Google App Engine
This is Rietveld 408576698