Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()

Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()

As implementation comments in MessagePort::messageAvailable(), it can be called
from another thread and should not call non-thread-functions. However, the
current implementation wrongly calls ContextLifecycleObserver's
GetExecutionContext() that is not a thread-safe function to post a task to the
context thread.

To avoid that, this CL replaces ExecutionContext::PostTask() with
WebTaskRunner::PostTask(). The task runner is captured in the ctor of
MessagePort called on the context thread.

BUG=694925
Review-Url: https://codereview.chromium.org/2818073002
Cr-Commit-Position: refs/heads/master@{#465886}
Committed: https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d0e45df1e8325

[nhiroki, 2017-04-14 05:51:39]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 05:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 07:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 07:42:55]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-18 02:18:24]

nhiroki@chromium.org changed reviewers:
+ tzik@chromium.org, yuryu@chromium.org

[nhiroki, 2017-04-18 02:18:25]

PTAL, thanks!

[tzik, 2017-04-18 02:26:39]

lgtm

[yuryu, 2017-04-18 02:34:16]

lgtm

[nhiroki, 2017-04-18 02:34:51]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2017-04-18 02:34:52]

+kinuko@, can you review this as an owner of core/? Thanks!

[kinuko, 2017-04-18 05:03:26]

lgtm

[nhiroki, 2017-04-20 01:51:05]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-04-20 01:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yuryu@chromium.org,
kinuko@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2818073002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-20 01:51:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 03:21:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492653065203890,
"parent_rev": "684e394da09c25aec471f4468211513244131235", "commit_rev":
"829907ac0d3d2ed39d8752d22a6d0e45df1e8325"}

[commit-bot: I haz the power, 2017-04-20 03:21:34]

Description was changed from

==========
Messaging: Avoid calling non-thread-safe functions in
MessagePort::messageAvailable()

As implementation comments in MessagePort::messageAvailable(), it can be called
from another thread and should not call non-thread-functions. However, the
current implementation wrongly calls ContextLifecycleObserver's
GetExecutionContext() that is not a thread-safe function to post a task to the
context thread.

To avoid that, this CL replaces ExecutionContext::PostTask() with
WebTaskRunner::PostTask(). The task runner is captured in the ctor of
MessagePort called on the context thread.

BUG=694925
==========

to

==========
Messaging: Avoid calling non-thread-safe functions in
MessagePort::messageAvailable()

As implementation comments in MessagePort::messageAvailable(), it can be called
from another thread and should not call non-thread-functions. However, the
current implementation wrongly calls ContextLifecycleObserver's
GetExecutionContext() that is not a thread-safe function to post a task to the
context thread.

To avoid that, this CL replaces ExecutionContext::PostTask() with
WebTaskRunner::PostTask(). The task runner is captured in the ctor of
MessagePort called on the context thread.

BUG=694925

Review-Url: https://codereview.chromium.org/2818073002
Cr-Commit-Position: refs/heads/master@{#465886}
Committed:
https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d...
==========

[commit-bot: I haz the power, 2017-04-20 03:21:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d...

[nhiroki, 2017-04-20 03:40:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2833673002/ by nhiroki@chromium.org.

The reason for reverting is: [1] that this CL depends on needs to be reverted:
https://codereview.chromium.org/2831843002/.