third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp - Issue 2836473002: Reland of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp

Issue 2836473002: Reland of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp

diff --git a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp

index d06127ef45ad27be71c9dda3875744c2eac89667..631c5de8c0ec7a26c67b96aea14956e1c38bf507 100644

--- a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp

+++ b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp

@@ -87,8 +87,7 @@

TaskType type,

WorkerOrWorkletGlobalScope* global_scope) {

DCHECK(global_scope);

- // TODO(nhiroki): Add |DCHECK(global_scope->IsContextThread())| here after

- // https://crbug.com/694925 is fixed.

+ DCHECK(global_scope->IsContextThread());

return Get(type, global_scope->GetThread());

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/MessagePort.cpp ('k') | no next file » | no next file with comments »