Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2833673002: Revert of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (Closed)

Created:
3 years, 8 months ago by nhiroki
Modified:
3 years, 8 months ago
Reviewers:
yuryu, kinuko, tzik
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (patchset #2 id:20001 of https://codereview.chromium.org/2818073002/ ) Reason for revert: [1] that this CL depends on needs to be reverted: https://codereview.chromium.org/2831843002/ Original issue's description: > Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() > > As implementation comments in MessagePort::messageAvailable(), it can be called > from another thread and should not call non-thread-functions. However, the > current implementation wrongly calls ContextLifecycleObserver's > GetExecutionContext() that is not a thread-safe function to post a task to the > context thread. > > To avoid that, this CL replaces ExecutionContext::PostTask() with > WebTaskRunner::PostTask(). The task runner is captured in the ctor of > MessagePort called on the context thread. > > BUG=694925 > > Review-Url: https://codereview.chromium.org/2818073002 > Cr-Commit-Position: refs/heads/master@{#465886} > Committed: https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d0e45df1e8325 TBR=tzik@chromium.org,yuryu@chromium.org,kinuko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694925 Review-Url: https://codereview.chromium.org/2833673002 Cr-Commit-Position: refs/heads/master@{#465890} Committed: https://chromium.googlesource.com/chromium/src/+/7cbe41ace5629ba6b9ec5502803f02fb2f09b0fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M third_party/WebKit/Source/core/dom/MessagePort.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 3 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
nhiroki
Created Revert of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()
3 years, 8 months ago (2017-04-20 03:40:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833673002/1
3 years, 8 months ago (2017-04-20 03:40:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7cbe41ace5629ba6b9ec5502803f02fb2f09b0fd
3 years, 8 months ago (2017-04-20 03:40:53 UTC) #6
nhiroki
3 years, 8 months ago (2017-04-20 23:01:46 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2836473002/ by nhiroki@chromium.org.

The reason for reverting is: The CL that this CL depends on was relanded:
https://codereview.chromium.org/2832763002/.

Powered by Google App Engine
This is Rietveld 408576698