Chromium Code Reviews
DescriptionRevert of Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable() (patchset #2 id:20001 of https://codereview.chromium.org/2818073002/ )
Reason for revert:
[1] that this CL depends on needs to be reverted:
https://codereview.chromium.org/2831843002/
Original issue's description:
> Messaging: Avoid calling non-thread-safe functions in MessagePort::messageAvailable()
>
> As implementation comments in MessagePort::messageAvailable(), it can be called
> from another thread and should not call non-thread-functions. However, the
> current implementation wrongly calls ContextLifecycleObserver's
> GetExecutionContext() that is not a thread-safe function to post a task to the
> context thread.
>
> To avoid that, this CL replaces ExecutionContext::PostTask() with
> WebTaskRunner::PostTask(). The task runner is captured in the ctor of
> MessagePort called on the context thread.
>
> BUG=694925
>
> Review-Url: https://codereview.chromium.org/2818073002
> Cr-Commit-Position: refs/heads/master@{#465886}
> Committed: https://chromium.googlesource.com/chromium/src/+/829907ac0d3d2ed39d8752d22a6d0e45df1e8325
TBR=tzik@chromium.org,yuryu@chromium.org,kinuko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=694925
Review-Url: https://codereview.chromium.org/2833673002
Cr-Commit-Position: refs/heads/master@{#465890}
Committed: https://chromium.googlesource.com/chromium/src/+/7cbe41ace5629ba6b9ec5502803f02fb2f09b0fd
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||