Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 2835923005: Reporting: Remove persistence for now. (Closed)

Created:
3 years, 8 months ago by Julia Tuttle
Modified:
3 years, 7 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Remove persistence for now. I'm going to build a general persistence mechanism for //net instead of tediously plumbing out to the profile's prefs (which gets really messy with isolated app contexts and such), so I'm removing the old persistence stuff until that's done. BUG=704259 Review-Url: https://codereview.chromium.org/2835923005 Cr-Commit-Position: refs/heads/master@{#467862} Committed: https://chromium.googlesource.com/chromium/src/+/42c573195110d731d47865d8d780db53b95a487b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -272 lines) Patch
M net/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M net/reporting/reporting_context.h View 4 chunks +1 line, -18 lines 0 comments Download
M net/reporting/reporting_context.cc View 4 chunks +1 line, -27 lines 0 comments Download
D net/reporting/reporting_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D net/reporting/reporting_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M net/reporting/reporting_delivery_agent.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/reporting/reporting_delivery_agent.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/reporting/reporting_garbage_collector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/reporting/reporting_garbage_collector.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M net/reporting/reporting_persister.h View 1 chunk +2 lines, -14 lines 0 comments Download
M net/reporting/reporting_persister.cc View 3 chunks +3 lines, -40 lines 0 comments Download
M net/reporting/reporting_persister_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/reporting/reporting_service.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/reporting/reporting_service.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M net/reporting/reporting_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/reporting/reporting_test_util.h View 8 chunks +5 lines, -36 lines 0 comments Download
M net/reporting/reporting_test_util.cc View 5 chunks +7 lines, -34 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 8 months ago (2017-04-25 20:55:07 UTC) #4
Julia Tuttle
On 2017/04/25 20:55:07, Julia Tuttle wrote: > PTAL, shivanisha. Ping?
3 years, 7 months ago (2017-04-27 18:57:36 UTC) #7
shivanisha
On 2017/04/27 at 18:57:36, juliatuttle wrote: > On 2017/04/25 20:55:07, Julia Tuttle wrote: > > ...
3 years, 7 months ago (2017-04-27 19:45:09 UTC) #8
shivanisha
On 2017/04/27 at 19:45:09, shivanisha wrote: > On 2017/04/27 at 18:57:36, juliatuttle wrote: > > ...
3 years, 7 months ago (2017-04-27 19:55:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835923005/1
3 years, 7 months ago (2017-04-27 22:30:25 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 03:04:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42c573195110d731d47865d8d780...

Powered by Google App Engine
This is Rietveld 408576698