Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: net/reporting/reporting_service.cc

Issue 2835923005: Reporting: Remove persistence for now. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/reporting/reporting_service.h ('k') | net/reporting/reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/reporting/reporting_service.cc
diff --git a/net/reporting/reporting_service.cc b/net/reporting/reporting_service.cc
index 6d2b215ce5f1f2c30b43e3a89d92d780ea445011..4dcee9da222bb8812a4df914fb037edf4ea67263 100644
--- a/net/reporting/reporting_service.cc
+++ b/net/reporting/reporting_service.cc
@@ -14,7 +14,6 @@
#include "base/values.h"
#include "net/reporting/reporting_cache.h"
#include "net/reporting/reporting_context.h"
-#include "net/reporting/reporting_delegate.h"
#include "net/reporting/reporting_header_parser.h"
#include "url/gurl.h"
@@ -25,11 +24,7 @@ namespace {
class ReportingServiceImpl : public ReportingService {
public:
ReportingServiceImpl(std::unique_ptr<ReportingContext> context)
- : context_(std::move(context)) {
- // TODO(juliatuttle): This can be slow, so it might be better to expose it
- // as a separate method and call it separately from constructing everything.
- context_->Initialize();
- }
+ : context_(std::move(context)) {}
~ReportingServiceImpl() override {}
@@ -37,14 +32,12 @@ class ReportingServiceImpl : public ReportingService {
const std::string& group,
const std::string& type,
std::unique_ptr<const base::Value> body) override {
- DCHECK(context_->initialized());
context_->cache()->AddReport(url, group, type, std::move(body),
context_->tick_clock()->NowTicks(), 0);
}
void ProcessHeader(const GURL& url,
const std::string& header_value) override {
- DCHECK(context_->initialized());
ReportingHeaderParser::ParseHeader(context_.get(), url, header_value);
}
@@ -61,10 +54,9 @@ ReportingService::~ReportingService() {}
// static
std::unique_ptr<ReportingService> ReportingService::Create(
const ReportingPolicy& policy,
- URLRequestContext* request_context,
- std::unique_ptr<ReportingDelegate> delegate) {
+ URLRequestContext* request_context) {
return base::MakeUnique<ReportingServiceImpl>(
- ReportingContext::Create(policy, std::move(delegate), request_context));
+ ReportingContext::Create(policy, request_context));
}
// static
« no previous file with comments | « net/reporting/reporting_service.h ('k') | net/reporting/reporting_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698