Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: net/reporting/reporting_context.h

Issue 2835923005: Reporting: Remove persistence for now. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/reporting/reporting_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/reporting/reporting_context.h
diff --git a/net/reporting/reporting_context.h b/net/reporting/reporting_context.h
index ca495a75a75ad0266fa1b0036fdea34e86f3f519..34e95d389e22e8251afb72907c9adabacb9f48fe 100644
--- a/net/reporting/reporting_context.h
+++ b/net/reporting/reporting_context.h
@@ -21,7 +21,6 @@ class TickClock;
namespace net {
class ReportingCache;
-class ReportingDelegate;
class ReportingDeliveryAgent;
class ReportingEndpointManager;
class ReportingGarbageCollector;
@@ -37,23 +36,11 @@ class NET_EXPORT ReportingContext {
public:
static std::unique_ptr<ReportingContext> Create(
const ReportingPolicy& policy,
- std::unique_ptr<ReportingDelegate> delegate,
URLRequestContext* request_context);
~ReportingContext();
- // Initializes the ReportingContext. This may take a while (e.g. it may
- // involve reloading state persisted to disk). Should be called only once.
- //
- // Components of the ReportingContext won't reference their dependencies (e.g.
- // the Clock/TickClock or Timers inside the individual components) until
- // during/after the call to Init.
- void Initialize();
-
- bool initialized() const { return initialized_; }
-
const ReportingPolicy& policy() { return policy_; }
- ReportingDelegate* delegate() { return delegate_.get(); }
base::Clock* clock() { return clock_.get(); }
base::TickClock* tick_clock() { return tick_clock_.get(); }
@@ -77,21 +64,18 @@ class NET_EXPORT ReportingContext {
protected:
ReportingContext(const ReportingPolicy& policy,
- std::unique_ptr<ReportingDelegate> delegate,
std::unique_ptr<base::Clock> clock,
std::unique_ptr<base::TickClock> tick_clock,
std::unique_ptr<ReportingUploader> uploader);
private:
ReportingPolicy policy_;
- std::unique_ptr<ReportingDelegate> delegate_;
std::unique_ptr<base::Clock> clock_;
std::unique_ptr<base::TickClock> tick_clock_;
std::unique_ptr<ReportingUploader> uploader_;
base::ObserverList<ReportingObserver, /* check_empty= */ true> observers_;
- bool initialized_;
std::unique_ptr<ReportingCache> cache_;
@@ -102,8 +86,7 @@ class NET_EXPORT ReportingContext {
// and |endpoint_manager_|.
std::unique_ptr<ReportingDeliveryAgent> delivery_agent_;
- // |persister_| must come after |delegate_|, |clock_|, |tick_clock_|, and
- // |cache_|.
+ // |persister_| must come after |clock_|, |tick_clock_|, and |cache_|.
std::unique_ptr<ReportingPersister> persister_;
// |garbage_collector_| must come after |tick_clock_| and |cache_|.
« no previous file with comments | « net/BUILD.gn ('k') | net/reporting/reporting_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698