Reporting: Set up in ProfileImplIOData.

Reporting: Set up in ProfileImplIOData.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL creates a barebones ChromeReportingDelegate, initializes the
ReportingService in ProfileImplIOData::InitializeInternal, and sets the
service on the URLRequestContext.

BUG=704259
Review-Url: https://codereview.chromium.org/2769083005
Cr-Commit-Position: refs/heads/master@{#468038}
Committed: https://chromium.googlesource.com/chromium/src/+/1d92f015d0b85e071f0040c53ccd8f145b55e4c1

[Julia Tuttle, 2017-03-24 20:11:00]

juliatuttle@chromium.org changed reviewers:
+ shivanisha@chromium.org

[Julia Tuttle, 2017-03-24 20:11:00]

PTAL, shivanisha.

[Julia Tuttle, 2017-03-31 16:28:04]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:35:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Julia Tuttle, 2017-04-07 22:37:31]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:16:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Julia Tuttle, 2017-04-18 18:51:16]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:14:25]

Dry run: This issue passed the CQ dry run.

[shivanisha, 2017-04-20 18:33:13]

On 2017/03/24 at 20:11:00, juliatuttle wrote:
> PTAL, shivanisha.

lgtm

[Julia Tuttle, 2017-04-20 20:04:35]

Thanks, shivanisha! PTAL csharrison for committer signoff.

[Julia Tuttle, 2017-04-20 20:04:45]

juliatuttle@chromium.org changed reviewers:
+ csharrison@chromium.org

[Julia Tuttle, 2017-04-20 20:04:46]

[+csharrison]

[Charlie Harrison, 2017-04-20 20:06:34]

On 2017/04/20 20:04:46, Julia Tuttle wrote:
> [+csharrison]

RS LGTM

[Julia Tuttle, 2017-04-20 20:07:38]

The CQ bit was checked by juliatuttle@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:17:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:17:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julia Tuttle, 2017-04-21 13:11:35]

juliatuttle@chromium.org changed reviewers:
+ mmenke@chromium.org

[Julia Tuttle, 2017-04-21 13:11:36]

mmenke, can you take a look at the //chrome/browser/profiles changes here? (If
not, I can find another reviewer.)

[mmenke, 2017-04-21 15:19:05]

On 2017/04/21 13:11:36, Julia Tuttle wrote:
> mmenke, can you take a look at the //chrome/browser/profiles changes here? (If
> not, I can find another reviewer.)

Should browsing data remover clear this class's state?  What about closing the
last incognito window?

[mmenke, 2017-04-21 15:19:38]

On 2017/04/21 15:19:05, mmenke wrote:
> On 2017/04/21 13:11:36, Julia Tuttle wrote:
> > mmenke, can you take a look at the //chrome/browser/profiles changes here?
(If
> > not, I can find another reviewer.)
> 
> Should browsing data remover clear this class's state?  What about closing the
> last incognito window?

Oops...Just noticed ProfileImplIoData, only, so ignore the incognito question.

[Julia Tuttle, 2017-04-21 18:31:33]

I haven't looked into incognito issues yet, but it's on my radar.

Did you have any comments or changes?

[mmenke, 2017-04-21 18:40:30]

On 2017/04/21 18:31:33, Julia Tuttle wrote:
> I haven't looked into incognito issues yet, but it's on my radar.
> 
> Did you have any comments or changes?

Other than flushing data in BrowsingDataRemover and friends, no.  I don't think
this should be landed until that's hooked up, even without incognito (Hooked up
to anything that clears cache or flushes socket pools, maybe?)

[mmenke, 2017-04-21 18:40:57]

On 2017/04/21 18:40:30, mmenke wrote:
> On 2017/04/21 18:31:33, Julia Tuttle wrote:
> > I haven't looked into incognito issues yet, but it's on my radar.
> > 
> > Did you have any comments or changes?
> 
> Other than flushing data in BrowsingDataRemover and friends, no.  I don't
think
> this should be landed until that's hooked up, even without incognito (Hooked
up
> to anything that clears cache or flushes socket pools, maybe?)

Actually, clearing site data should flush this, I guess.  Less sure about cache.

[mmenke, 2017-04-21 19:51:55]

Julia pointed out that this is behind a flag, and she's already working on
hooking it up to BrowserDataRemover, which is good enough for me.


However, I also think we should also give each AppRequestContext its own
ReportingService (Which uses the AppRequestContext for reports), to keep app
requests isolated.  Apps have their own cookie stores and channel ID stores, so
we should at least make some effort to prevent cross-URLRequestContext sniffing.

We may also want to add a ReportingService to the IOThread's system
URLRequestContext, but I don't think that's a blocker.

One other concern is SafeBrowsing's URLRequestContext:  It uses its own cookie
store, and is very conscious of cross-URLRequestContext contamination, since it
makes automatic requests to Google services in cases when other things normally
don't, but it does share the main URLRequestContext's machinery (Other than
cookie store and NetworkSession).  We should talk to the SafeBrowsing folks
about the best solution here.  We could just removing the ReportingService, but
it may be best to give it it's own service, since we presumably care quite a bit
if safebrowsing requests are being blocked.

[Julia Tuttle, 2017-04-24 14:49:16]

Matt, do you think we need to be able to persist Reporting data in app contexts
as well?

[Julia Tuttle, 2017-04-24 15:27:09]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 15:27:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:36:15]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-04-25 17:57:58]

On 2017/04/24 14:49:16, Julia Tuttle wrote:
> Matt, do you think we need to be able to persist Reporting data in app
contexts
> as well?

Yea, I think we do.  Look at how they handle the cookie store: 
https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_impl_io_...
(Also note the ephemeral check)

[Julia Tuttle, 2017-04-25 20:56:45]

PTAL, mmenke.

I've punted the persistence stuff until I implement a centralized persistence
system for //net.

[mmenke, 2017-04-26 20:17:12]

On 2017/04/25 20:56:45, Julia Tuttle wrote:
> PTAL, mmenke.
> 
> I've punted the persistence stuff until I implement a centralized persistence
> system for //net.

LGTM, sorry I didn't get to this earlier, forgot about this one.

[Julia Tuttle, 2017-04-27 16:47:56]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2017-04-27 16:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
shivanisha@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2769083005/#ps140001
(title: "Remove persistence for now.")

[commit-bot: I haz the power, 2017-04-27 16:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:48:42]

This CL has an open dependency (Issue 2835923005 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Julia Tuttle, 2017-04-28 14:18:11]

The CQ bit was checked by juliatuttle@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:18:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:22:32]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Julia Tuttle, 2017-04-28 14:37:28]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 14:38:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2017-04-28 15:52:49]

The CQ bit was unchecked by juliatuttle@chromium.org

[Julia Tuttle, 2017-04-28 15:52:51]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2017-04-28 15:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
shivanisha@chromium.org, mmenke@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2769083005/#ps160001
(title: "rebase")

[Julia Tuttle, 2017-04-28 15:52:55]

The CQ bit was checked by juliatuttle@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:53:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 17:19:24]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493394775450610,
"parent_rev": "c4d0415066d9a0f98eb98179f49679906da55c87", "commit_rev":
"1d92f015d0b85e071f0040c53ccd8f145b55e4c1"}

[commit-bot: I haz the power, 2017-04-28 17:19:37]

Description was changed from

==========
Reporting: Set up in ProfileImplIOData.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL creates a barebones ChromeReportingDelegate, initializes the
ReportingService in ProfileImplIOData::InitializeInternal, and sets the
service on the URLRequestContext.

BUG=704259
==========

to

==========
Reporting: Set up in ProfileImplIOData.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL creates a barebones ChromeReportingDelegate, initializes the
ReportingService in ProfileImplIOData::InitializeInternal, and sets the
service on the URLRequestContext.

BUG=704259

Review-Url: https://codereview.chromium.org/2769083005
Cr-Commit-Position: refs/heads/master@{#468038}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d92f015d0b85e071f0040c53ccd...
==========

[commit-bot: I haz the power, 2017-04-28 17:19:39]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/1d92f015d0b85e071f0040c53ccd...