Reland of Add U2F request state machines

Reland of Add U2F request state machines (patchset #1 id:1 of https://codereview.chromium.org/2838573002/ )

Reason for revert:
Missing initialized variable can be initialized and this patchset can be merged again.

Original issue's description:
> Revert of Add U2F request state machines (patchset #5 id:180001 of https://codereview.chromium.org/2821263005/ )
> 
> Reason for revert:
> Reverting because U2fRequestTest.TestBasicMachine fails consistently on MSan bots (Linux MSan, Linux ChromiumOS MSan).
> 
> Original issue's description:
> > Add U2F request state machines
> > 
> > U2fRequest base class is extended by each type of U2F
> > request. Common functions of enumeration and device iteration
> > are defined in the base class. U2fSign performs an entire
> > sign request on any attached U2F devices, and U2FRegister
> > performs the registration request on the devices.
> > 
> > BUG=686310
> > 
> > Review-Url: https://codereview.chromium.org/2821263005
> > Cr-Commit-Position: refs/heads/master@{#466529}
> > Committed: https://chromium.googlesource.com/chromium/src/+/892eb34117f811aa62c821c9129dc53110266e9a
> 
> TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc@google.com,piperc@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=686310
> 
> Review-Url: https://codereview.chromium.org/2838573002
> Cr-Commit-Position: refs/heads/master@{#466666}
> Committed: https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba505308efd5ab23

TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc@google.com,pkalinnikov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686310
Review-Url: https://codereview.chromium.org/2835133003
Cr-Commit-Position: refs/heads/master@{#466872}
Committed: https://chromium.googlesource.com/chromium/src/+/4263ec46010ddf5329f20c2d582bb5d2606e0e49

[Casey Piper, 2017-04-24 20:53:57]

The CQ bit was checked by piperc@chromium.org

[Casey Piper, 2017-04-24 20:53:58]

Created Reland of Add U2F request state machines

[Casey Piper, 2017-04-24 20:54:04]

The CQ bit was unchecked by piperc@chromium.org

[Casey Piper, 2017-04-24 21:05:19]

Patchset #2 (id:290001) has been deleted

[Reilly Grant (use Gerrit), 2017-04-24 21:07:49]

lgtm with nits

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
File device/u2f/u2f_hid_device.cc (right):

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
device/u2f/u2f_hid_device.cc:29: capabilities_ = 0;
nit: combine these lines with the initialization of other member variables
above.

[Casey Piper, 2017-04-24 21:21:23]

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
File device/u2f/u2f_hid_device.cc (right):

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
device/u2f/u2f_hid_device.cc:29: capabilities_ = 0;
On 2017/04/24 21:07:49, Reilly Grant wrote:
> nit: combine these lines with the initialization of other member variables
> above.

Since the variables are from the base class, is there a way to initialize them
in the initialization list?

[Reilly Grant (use Gerrit), 2017-04-24 21:38:37]

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
File device/u2f/u2f_hid_device.cc (right):

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
device/u2f/u2f_hid_device.cc:29: capabilities_ = 0;
On 2017/04/24 21:21:23, Casey Piper wrote:
> On 2017/04/24 21:07:49, Reilly Grant wrote:
> > nit: combine these lines with the initialization of other member variables
> > above.
> 
> Since the variables are from the base class, is there a way to initialize them
> in the initialization list?

Oh, I didn't realize they were in the base class. They should be initialized in
the base class constructor then.

[Casey Piper, 2017-04-24 22:52:53]

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
File device/u2f/u2f_hid_device.cc (right):

https://codereview.chromium.org/2835133003/diff/310001/device/u2f/u2f_hid_dev...
device/u2f/u2f_hid_device.cc:29: capabilities_ = 0;
On 2017/04/24 21:38:37, Reilly Grant wrote:
> On 2017/04/24 21:21:23, Casey Piper wrote:
> > On 2017/04/24 21:07:49, Reilly Grant wrote:
> > > nit: combine these lines with the initialization of other member variables
> > > above.
> > 
> > Since the variables are from the base class, is there a way to initialize
them
> > in the initialization list?
> 
> Oh, I didn't realize they were in the base class. They should be initialized
in
> the base class constructor then.

Done.

[Casey Piper, 2017-04-24 22:53:01]

The CQ bit was checked by piperc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 22:53:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 22:53:34]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-24 23:08:19]

lgtm

https://codereview.chromium.org/2835133003/diff/330001/device/u2f/u2f_hid_dev...
File device/u2f/u2f_hid_device.cc (right):

https://codereview.chromium.org/2835133003/diff/330001/device/u2f/u2f_hid_dev...
device/u2f/u2f_hid_device.cc:27: weak_factory_(this) {
U2fHidDevice should share its parent class's WeakPtrFactory. (Separate patch.)

[Casey Piper, 2017-04-24 23:56:02]

The CQ bit was checked by piperc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 23:56:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:56:38]

Dry run: This issue passed the CQ dry run.

[Casey Piper, 2017-04-25 02:29:38]

The CQ bit was checked by piperc@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:30:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 02:30:51]

CQ is committing da patch.

Bot data: {"patchset_id": 330001, "attempt_start_ts": 1493087378249420,
"parent_rev": "4c5022c615824a6e2ad67db5eec5a093e3111e2d", "commit_rev":
"4263ec46010ddf5329f20c2d582bb5d2606e0e49"}

[commit-bot: I haz the power, 2017-04-25 02:31:04]

Description was changed from

==========
Reland of Add U2F request state machines (patchset #1 id:1 of
https://codereview.chromium.org/2838573002/ )

Reason for revert:
Missing initialized variable can be initialized and this patchset can be merged
again.

Original issue's description:
> Revert of Add U2F request state machines (patchset #5 id:180001 of
https://codereview.chromium.org/2821263005/ )
> 
> Reason for revert:
> Reverting because U2fRequestTest.TestBasicMachine fails consistently on MSan
bots (Linux MSan, Linux ChromiumOS MSan).
> 
> Original issue's description:
> > Add U2F request state machines
> > 
> > U2fRequest base class is extended by each type of U2F
> > request. Common functions of enumeration and device iteration
> > are defined in the base class. U2fSign performs an entire
> > sign request on any attached U2F devices, and U2FRegister
> > performs the registration request on the devices.
> > 
> > BUG=686310
> > 
> > Review-Url: https://codereview.chromium.org/2821263005
> > Cr-Commit-Position: refs/heads/master@{#466529}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/892eb34117f811aa62c821c9129d...
> 
>
TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=686310
> 
> Review-Url: https://codereview.chromium.org/2838573002
> Cr-Commit-Position: refs/heads/master@{#466666}
> Committed:
https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba50...

TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686310
==========

to

==========
Reland of Add U2F request state machines (patchset #1 id:1 of
https://codereview.chromium.org/2838573002/ )

Reason for revert:
Missing initialized variable can be initialized and this patchset can be merged
again.

Original issue's description:
> Revert of Add U2F request state machines (patchset #5 id:180001 of
https://codereview.chromium.org/2821263005/ )
> 
> Reason for revert:
> Reverting because U2fRequestTest.TestBasicMachine fails consistently on MSan
bots (Linux MSan, Linux ChromiumOS MSan).
> 
> Original issue's description:
> > Add U2F request state machines
> > 
> > U2fRequest base class is extended by each type of U2F
> > request. Common functions of enumeration and device iteration
> > are defined in the base class. U2fSign performs an entire
> > sign request on any attached U2F devices, and U2FRegister
> > performs the registration request on the devices.
> > 
> > BUG=686310
> > 
> > Review-Url: https://codereview.chromium.org/2821263005
> > Cr-Commit-Position: refs/heads/master@{#466529}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/892eb34117f811aa62c821c9129d...
> 
>
TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=686310
> 
> Review-Url: https://codereview.chromium.org/2838573002
> Cr-Commit-Position: refs/heads/master@{#466666}
> Committed:
https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba50...

TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686310

Review-Url: https://codereview.chromium.org/2835133003
Cr-Commit-Position: refs/heads/master@{#466872}
Committed:
https://chromium.googlesource.com/chromium/src/+/4263ec46010ddf5329f20c2d582b...
==========

[commit-bot: I haz the power, 2017-04-25 02:31:06]

Committed patchset #3 (id:330001) as
https://chromium.googlesource.com/chromium/src/+/4263ec46010ddf5329f20c2d582b...