Reland of Add U2F request state machines

device/u2f/u2f_hid_device.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "u2f_hid_device.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "crypto/random.h"
 #include "device/base/device_client.h"
 #include "device/hid/hid_connection.h"
 #include "u2f_apdu_command.h"
 #include "u2f_message.h"
 
 namespace device {
 
 namespace switches {
 static constexpr char kEnableU2fHidTest[] = "enable-u2f-hid-tests";
 }  // namespace switches
 
 U2fHidDevice::U2fHidDevice(scoped_refptr<HidDeviceInfo> device_info)
     : U2fDevice(),
       state_(State::INIT),
       device_info_(device_info),
       weak_factory_(this) {
   channel_id_ = kBroadcastChannel;
+  capabilities_ = 0;

[Reilly Grant (use Gerrit), 2017/04/24 21:07:49]

nit: combine these lines with the initialization of other member variables
above.

[Casey Piper, 2017/04/24 21:21:23]

Since the variables are from the base class, is there a way to initialize them
in the initialization list?

[Reilly Grant (use Gerrit), 2017/04/24 21:38:37]

Oh, I didn't realize they were in the base class. They should be initialized in
the base class constructor then.

[Casey Piper, 2017/04/24 22:52:53]

Done.

 }
 
 U2fHidDevice::~U2fHidDevice() {
   // Cleanup connection
   if (connection_ && !connection_->closed())
     connection_->Close();
 }
 
 void U2fHidDevice::DeviceTransact(std::unique_ptr<U2fApduCommand> command,
                                   const DeviceCallback& callback) {
@@ skipping 298 matching lines @@
   return id.str();
 }
 
 // static
 bool U2fHidDevice::IsTestEnabled() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   return command_line->HasSwitch(switches::kEnableU2fHidTest);
 }
 
 }  // namespace device