Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2838573002: Revert of Add U2F request state machines (Closed)

Created:
3 years, 8 months ago by pkalinnikov
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add U2F request state machines (patchset #5 id:180001 of https://codereview.chromium.org/2821263005/ ) Reason for revert: Reverting because U2fRequestTest.TestBasicMachine fails consistently on MSan bots (Linux MSan, Linux ChromiumOS MSan). Original issue's description: > Add U2F request state machines > > U2fRequest base class is extended by each type of U2F > request. Common functions of enumeration and device iteration > are defined in the base class. U2fSign performs an entire > sign request on any attached U2F devices, and U2FRegister > performs the registration request on the devices. > > BUG=686310 > > Review-Url: https://codereview.chromium.org/2821263005 > Cr-Commit-Position: refs/heads/master@{#466529} > Committed: https://chromium.googlesource.com/chromium/src/+/892eb34117f811aa62c821c9129dc53110266e9a TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc@google.com,piperc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=686310 Review-Url: https://codereview.chromium.org/2838573002 Cr-Commit-Position: refs/heads/master@{#466666} Committed: https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba505308efd5ab23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1117 lines) Patch
M device/BUILD.gn View 3 chunks +3 lines, -7 lines 0 comments Download
M device/u2f/BUILD.gn View 2 chunks +0 lines, -22 lines 0 comments Download
D device/u2f/mock_u2f_device.h View 1 chunk +0 lines, -43 lines 0 comments Download
D device/u2f/mock_u2f_device.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M device/u2f/u2f_apdu_response.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/u2f/u2f_device.h View 2 chunks +7 lines, -2 lines 0 comments Download
M device/u2f/u2f_device.cc View 4 chunks +13 lines, -12 lines 0 comments Download
D device/u2f/u2f_register.h View 1 chunk +0 lines, -37 lines 0 comments Download
D device/u2f/u2f_register.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D device/u2f/u2f_register_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D device/u2f/u2f_request.h View 1 chunk +0 lines, -65 lines 0 comments Download
D device/u2f/u2f_request.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D device/u2f/u2f_request_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D device/u2f/u2f_return_code.h View 1 chunk +0 lines, -19 lines 0 comments Download
D device/u2f/u2f_sign.h View 1 chunk +0 lines, -51 lines 0 comments Download
D device/u2f/u2f_sign.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D device/u2f/u2f_sign_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pkalinnikov
Created Revert of Add U2F request state machines
3 years, 8 months ago (2017-04-24 11:49:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838573002/1
3 years, 8 months ago (2017-04-24 11:49:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437298)
3 years, 8 months ago (2017-04-24 14:45:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838573002/1
3 years, 8 months ago (2017-04-24 14:46:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba505308efd5ab23
3 years, 7 months ago (2017-04-24 17:16:24 UTC) #10
Casey Piper
3 years, 7 months ago (2017-04-24 20:53:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2835133003/ by piperc@chromium.org.

The reason for reverting is: Missing initialized variable can be initialized and
this patchset can be merged again..

Powered by Google App Engine
This is Rietveld 408576698