[Android O] Refactor channel definitions into new class

[Android O] Refactor channel definitions into new class

- As discussed, we can give this a per-file OWNERS for added safety
in case of channels being updated without increasing the version number.

- In future there will also be a requirement to move deprecated channels
into a new map, and thus a further need for safety.

- This refactoring will also make testing easier as fake channel
definitions can now be easily supplied in tests.

Review-Url: https://codereview.chromium.org/2832433002
Cr-Commit-Position: refs/heads/master@{#466316}
Committed: https://chromium.googlesource.com/chromium/src/+/8aacc8f8d02e5b19f491b34f744085dd2c521167

[awdf, 2017-04-19 14:41:18]

awdf@chromium.org changed reviewers:
+ peter@chromium.org

[awdf, 2017-04-19 14:41:18]

Erm so how *do* I make it so this file can only be edited by a restricted set of
owners? Do I need to edit chrome/browser/android/OWNERS or add a new OWNERS
file?

[Peter Beverloo, 2017-04-19 15:00:36]

lgtm, wdyt Tommy, David?

https://codereview.chromium.org/2832433002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelDefinitions.java
(right):

https://codereview.chromium.org/2832433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelDefinitions.java:19:
public class ChannelDefinitions {
nit: add a comment detailing what the purpose of this class is, and duplicate
the OWNERS file comment about why it's restricted.

[awdf, 2017-04-19 15:17:22]

awdf@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[awdf, 2017-04-19 15:17:23]

+nyquist@ and dtrainor@ for approval on becoming per-file owners of channel
definitions.

[David Trainor- moved to gerrit, 2017-04-19 18:05:36]

channel owners and comment lgtm.  the power!!!!

[nyquist, 2017-04-19 20:56:19]

lgtm!

[awdf, 2017-04-20 16:39:09]

The CQ bit was checked by awdf@chromium.org

[awdf, 2017-04-20 16:39:10]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2832433002/#ps40001
(title: "add a fullstop")

[commit-bot: I haz the power, 2017-04-20 16:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 16:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:48:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[awdf, 2017-04-20 22:58:31]

The CQ bit was checked by awdf@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[awdf, 2017-04-20 22:59:50]

The CQ bit was unchecked by awdf@chromium.org

[awdf, 2017-04-21 11:22:09]

The CQ bit was checked by awdf@chromium.org

[awdf, 2017-04-21 11:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
nyquist@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2832433002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-21 11:22:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 12:27:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492773729739180,
"parent_rev": "43525ec7a4ebf72cc88ad3edfad53b5be3c59b61", "commit_rev":
"8aacc8f8d02e5b19f491b34f744085dd2c521167"}

[commit-bot: I haz the power, 2017-04-21 12:27:48]

Description was changed from

==========
[Android O] Refactor channel definitions into new class

- As discussed, we can give this a per-file OWNERS for added safety
in case of channels being updated without increasing the version number.

- In future there will also be a requirement to move deprecated channels
into a new map, and thus a further need for safety.

- This refactoring will also make testing easier as fake channel
definitions can now be easily supplied in tests.
==========

to

==========
[Android O] Refactor channel definitions into new class

- As discussed, we can give this a per-file OWNERS for added safety
in case of channels being updated without increasing the version number.

- In future there will also be a requirement to move deprecated channels
into a new map, and thus a further need for safety.

- This refactoring will also make testing easier as fake channel
definitions can now be easily supplied in tests.

Review-Url: https://codereview.chromium.org/2832433002
Cr-Commit-Position: refs/heads/master@{#466316}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aacc8f8d02e5b19f491b34f7440...
==========

[commit-bot: I haz the power, 2017-04-21 12:27:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8aacc8f8d02e5b19f491b34f7440...