chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java - Issue 2832433002: [Android O] Refactor channel definitions into new class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

Issue 2832433002: [Android O] Refactor channel definitions into new class (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

index 75ea39bf68f8cd1b02117712cc8db095c6f148f1..150862bf0042b131a52c017a697dcac20e53d57e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

@@ -18,10 +18,10 @@ public interface NotificationManagerProxy {

void cancel(int id);

void cancel(String tag, int id);

void cancelAll();

- void createNotificationChannel(ChannelsInitializer.Channel channel);

- void createNotificationChannelGroup(ChannelsInitializer.ChannelGroup channelGroup);

+ void createNotificationChannel(ChannelDefinitions.Channel channel);

+ void createNotificationChannelGroup(ChannelDefinitions.ChannelGroup channelGroup);

List<String> getNotificationChannelIds();

- void deleteNotificationChannel(@ChannelsInitializer.ChannelId String id);

+ void deleteNotificationChannel(@ChannelDefinitions.ChannelId String id);

void notify(int id, Notification notification);

void notify(String tag, int id, Notification notification);