chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS - Issue 2832433002: [Android O] Refactor channel definitions into new class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS

Issue 2832433002: [Android O] Refactor channel definitions into new class (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS b/chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS

index b72822a75188930ebdc6bfb9e0a8559789413121..97e3fd41a4fba8b9d5fc1b3ed4f1f3687eeaad47 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/OWNERS

@@ -8,5 +8,14 @@ awdf@chromium.org

miguelg@chromium.org

peter@chromium.org

+# Notification channels appear in system UI and are persisted forever by Android, so should not be

+# added or removed lightly, and the proper deprecation and versioning steps must be taken when doing

+# so. Please read the file comments and speak to one of us when adding/removing a channel.

+per-file ChannelDefinitions.java=set noparent

+per-file ChannelDefinitions.java=awdf@chromium.org

+per-file ChannelDefinitions.java=peter@chromium.org

+per-file ChannelDefinitions.java=nyquist@chromium.org

+per-file ChannelDefinitions.java=dtrainor@chromium.org

# TEAM: platform-capabilities@chromium.org

# COMPONENT: UI>Notifications