chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java - Issue 2832433002: [Android O] Refactor channel definitions into new class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Issue 2832433002: [Android O] Refactor channel definitions into new class (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelDefinitions.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

index 90bf8e871c92724051e5446e11afaf8f8586f295..198ca1c171c391013dd0a92ebe35ddf64ea7b76a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

@@ -38,7 +38,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.blink.mojom.MediaSessionAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.AppHooks;

-import org.chromium.chrome.browser.notifications.ChannelsInitializer;

+import org.chromium.chrome.browser.notifications.ChannelDefinitions;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

import org.chromium.chrome.browser.notifications.NotificationConstants;

@@ -813,7 +813,7 @@ public class MediaNotificationManager {

@VisibleForTesting

void updateNotificationBuilder() {

mNotificationBuilder = NotificationBuilderFactory.createChromeNotificationBuilder(

- true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_MEDIA);

+ true /* preferCompat */, ChannelDefinitions.CHANNEL_ID_MEDIA);

setMediaStyleLayoutForNotificationBuilder(mNotificationBuilder);

// TODO(zqzhang): It's weird that setShowWhen() doesn't work on K. Calling setWhen() to