Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2832193002: Revert of [regexp] Remove remainder of native RegExpExecStub (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
CC:
georgia.kouveli, Benedikt Meurer, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Remove remainder of native RegExpExecStub (patchset #10 id:180001 of https://codereview.chromium.org/2752143003/ ) Reason for revert: More failures on ports: https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20-%20builder/builds/9123/steps/compile/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/8966/steps/compile/logs/stdio Original issue's description: > [regexp] Remove remainder of native RegExpExecStub > > If we avoid throwing a stack overflow exception from Irregexp code during > direct calls, there is no need to construct exit frames before the Irregexp > call anymore. As that was the last remaining blocker, we can now implement the > entire stub in CSA. > > BUG=v8:5339 > > Review-Url: https://codereview.chromium.org/2752143003 > Cr-Original-Commit-Position: refs/heads/master@{#44770} > Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf > Review-Url: https://codereview.chromium.org/2752143003 > Cr-Commit-Position: refs/heads/master@{#44775} > Committed: https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a TBR=ishell@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Review-Url: https://codereview.chromium.org/2832193002 Cr-Commit-Position: refs/heads/master@{#44776} Committed: https://chromium.googlesource.com/v8/v8/+/b2aba7d768fe8ae56f7b66bd353c88349f5bfebe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+946 lines, -219 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.h View 2 chunks +10 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm64/simulator-arm64.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-regexp-gen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp-gen.cc View 8 chunks +40 lines, -98 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.h View 3 chunks +9 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.h View 2 chunks +11 lines, -5 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 2 chunks +17 lines, -9 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M src/regexp/s390/regexp-macro-assembler-s390.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/s390/regexp-macro-assembler-s390.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.h View 2 chunks +8 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jgruber
Created Revert of [regexp] Remove remainder of native RegExpExecStub
3 years, 8 months ago (2017-04-21 13:16:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832193002/1
3 years, 8 months ago (2017-04-21 13:16:23 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 13:16:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b2aba7d768fe8ae56f7b66bd353c88349f5...

Powered by Google App Engine
This is Rietveld 408576698