[regexp] Remove remainder of native RegExpExecStub

[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339
Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Original-Commit-Position: refs/heads/master@{#44770}
Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf
Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44775}
Committed: https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44779}
Committed: https://chromium.googlesource.com/v8/v8/+/1a02b627b3dede3ee37c1ec00e0b5c4919749322

[jgruber, 2017-03-16 08:08:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:08:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 08:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 08:13:57]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[jgruber, 2017-03-21 11:39:02]

Blocked by crbug.com/v8/6102.

[jgruber, 2017-04-19 11:43:17]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 11:43:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 11:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 11:44:53]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/24638)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/24546)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[jgruber, 2017-04-19 12:13:22]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 12:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 12:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 12:20:55]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[jgruber, 2017-04-19 13:17:29]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 13:17:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 13:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 13:24:24]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[jgruber, 2017-04-19 13:26:14]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 13:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 13:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 13:32:33]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[georgia.kouveli, 2017-04-19 15:57:26]

Some minor comments about comments.

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:79: *  - fp[80]  Isolate*
isolate   (address of the current isolate)               kIsolate
The corresponding comments for arm and arm64 are also out of date now (they also
mention the secondary return address in the frame layout description, in the
signature of "match" and also mention exit frames).

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:120: *              void*
return_address,
return_address is removed now?

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:127: * direct call from
generated code, the return address is placed there by
Another mention of the return address and exit frames.

[jgruber, 2017-04-20 09:36:59]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 09:37:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-20 09:37:48]

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:79: *  - fp[80]  Isolate*
isolate   (address of the current isolate)               kIsolate
On 2017/04/19 15:57:26, georgia.kouveli wrote:
> The corresponding comments for arm and arm64 are also out of date now (they
also
> mention the secondary return address in the frame layout description, in the
> signature of "match" and also mention exit frames).

Thanks, good point. I made a pass through the comments for all architectures and
updated all of them (+ some drive-by fixes).

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:120: *              void*
return_address,
On 2017/04/19 15:57:26, georgia.kouveli wrote:
> return_address is removed now?

Removed.

https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regex...
src/regexp/mips64/regexp-macro-assembler-mips64.cc:127: * direct call from
generated code, the return address is placed there by
On 2017/04/19 15:57:26, georgia.kouveli wrote:
> Another mention of the return address and exit frames.

Removed this entire paragraph.

[commit-bot: I haz the power, 2017-04-20 09:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 09:44:38]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[jgruber, 2017-04-20 11:36:17]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[jgruber, 2017-04-20 11:36:18]

Reviewer's guide since this has become fairly large:

* code-factory.{h,cc}:
* code-stubs-*.cc:
* interface-descriptors-*.cc: Removed RegExpExecStub

* simulator-*.h:
* regexp-macro-assembler-*.h: Removed artificial kSecondaryReturnAddress
argument. Not required anymore since we now use a standard C-linkage call
without exit frames.

* regexp-macro-assembler-*.cc: Updated comments with some drive-by fixes for
outdated infos.

* builtins-regexp-gen.cc: The main part of this CL. Irregexp code is now called
using CallCFunction9.

* code-assembler.{h,cc}:
* raw-machine-assembler.{h,cc}: CallCFunction9.

PTAL.

Note that the arm64 test failure will be fixed by
https://codereview.chromium.org/2833463002.

[jgruber, 2017-04-20 13:49:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 13:49:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 13:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 13:51:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/24708)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39485)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Igor Sheludko, 2017-04-20 15:08:08]

lgtm with nits:

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:384: // Argument 3: End of string data.
I'd move this comment down.

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:432: GotoIf(IntPtrEqual(int_result,
IntPtrConstant(1)), &if_success);
s/1/NativeRegExpMacroAssembler::SUCCESS/

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:511: USE(pending_exception_address);
I'd wrap this block in #ifdef DEBUG/#endif instead of using USE here.

https://codereview.chromium.org/2752143003/diff/100001/src/mips64/simulator-m...
File src/mips64/simulator-mips64.h (right):

https://codereview.chromium.org/2752143003/diff/100001/src/mips64/simulator-m...
src/mips64/simulator-mips64.h:562: entry, 10, p0, p1, p2, p3, p4,
reinterpret_cast<int64_t*>(p5), p6, p7,   \
Probably this reinterpret_cast<int64_t*> is also no longer necessary.

[jgruber, 2017-04-21 10:41:34]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 10:41:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-21 10:41:47]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339
==========

[jgruber, 2017-04-21 10:41:47]

jgruber@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[jgruber, 2017-04-21 10:42:33]

+mstarzinger for compiler/ (CallCFunction9)

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:384: // Argument 3: End of string data.
On 2017/04/20 15:08:07, Igor Sheludko wrote:
> I'd move this comment down.

Done.

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:432: GotoIf(IntPtrEqual(int_result,
IntPtrConstant(1)), &if_success);
On 2017/04/20 15:08:07, Igor Sheludko wrote:
> s/1/NativeRegExpMacroAssembler::SUCCESS/

Done.

https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-...
src/builtins/builtins-regexp-gen.cc:511: USE(pending_exception_address);
On 2017/04/20 15:08:07, Igor Sheludko wrote:
> I'd wrap this block in #ifdef DEBUG/#endif instead of using USE here.

Done.

https://codereview.chromium.org/2752143003/diff/100001/src/mips64/simulator-m...
File src/mips64/simulator-mips64.h (right):

https://codereview.chromium.org/2752143003/diff/100001/src/mips64/simulator-m...
src/mips64/simulator-mips64.h:562: entry, 10, p0, p1, p2, p3, p4,
reinterpret_cast<int64_t*>(p5), p6, p7,   \
On 2017/04/20 15:08:07, Igor Sheludko wrote:
> Probably this reinterpret_cast<int64_t*> is also no longer necessary.

Done.

[commit-bot: I haz the power, 2017-04-21 11:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 11:08:35]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-04-21 11:14:10]

LGTM.

[jgruber, 2017-04-21 11:44:30]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-21 11:44:30]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2752143003/#ps140001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-21 11:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 11:46:24]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492775070182590,
"parent_rev": "2815796510fb6cc4b30284983f3648b31a3b1b2b", "commit_rev":
"74f2497eae068f85da26904d8c451376c77957bf"}

[commit-bot: I haz the power, 2017-04-21 11:46:29]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
==========

[commit-bot: I haz the power, 2017-04-21 11:46:31]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...

[Michael Achenbach, 2017-04-21 12:01:23]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2833083002/ by machenbach@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20....

[Michael Achenbach, 2017-04-21 12:01:35]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2827243005/ by machenbach@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20....

[jgruber, 2017-04-21 12:35:10]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
==========

[jgruber, 2017-04-21 12:35:39]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-21 12:35:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2752143003/#ps180001
(title: "Revert sim-mips64 change")

[commit-bot: I haz the power, 2017-04-21 12:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-21 12:36:23]

On 2017/04/21 12:01:35, Michael Achenbach wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/2827243005/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20....

The reinterpret_cast<int64_t*> was necessary after all. Reverted that change and
relanding.

[commit-bot: I haz the power, 2017-04-21 13:02:11]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492778139631120,
"parent_rev": "43c20d4cc566c68ce0b566cad0ac6fa92bba8eff", "commit_rev":
"9c0832eb1aceba625a2443a31d51bcaf550c575a"}

[commit-bot: I haz the power, 2017-04-21 13:02:16]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44775}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...
==========

[commit-bot: I haz the power, 2017-04-21 13:02:18]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...

[jgruber, 2017-04-21 13:16:12]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2832193002/ by jgruber@chromium.org.

The reason for reverting is: More failures on ports:

https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20...

https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder....

[jgruber, 2017-04-21 13:32:22]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44775}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44775}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...
==========

[jgruber, 2017-04-21 13:33:53]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 13:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 13:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 13:59:56]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-21 14:00:19]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-04-21 14:01:42]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-21 14:01:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2752143003/#ps200001
(title: "Fix non-sim arm64 and mips builds")

[commit-bot: I haz the power, 2017-04-21 14:01:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:03:35]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1492783302372900,
"parent_rev": "dfdfc4e0234be6f2f149b0c9e5a4c37f382c7a18", "commit_rev":
"1a02b627b3dede3ee37c1ec00e0b5c4919749322"}

[commit-bot: I haz the power, 2017-04-21 14:03:41]

Description was changed from

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44775}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...
==========

to

==========
[regexp] Remove remainder of native RegExpExecStub

If we avoid throwing a stack overflow exception from Irregexp code during
direct calls, there is no need to construct exit frames before the Irregexp
call anymore. As that was the last remaining blocker, we can now implement the
entire stub in CSA.

BUG=v8:5339

Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Original-Commit-Position: refs/heads/master@{#44770}
Committed:
https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Original-Commit-Position: refs/heads/master@{#44775}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550...
Review-Url: https://codereview.chromium.org/2752143003
Cr-Commit-Position: refs/heads/master@{#44779}
Committed:
https://chromium.googlesource.com/v8/v8/+/1a02b627b3dede3ee37c1ec00e0b5c49197...
==========

[commit-bot: I haz the power, 2017-04-21 14:03:43]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/1a02b627b3dede3ee37c1ec00e0b5c49197...