Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2752143003: [regexp] Remove remainder of native RegExpExecStub (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 8 months ago
CC:
georgia.kouveli, Benedikt Meurer, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove remainder of native RegExpExecStub If we avoid throwing a stack overflow exception from Irregexp code during direct calls, there is no need to construct exit frames before the Irregexp call anymore. As that was the last remaining blocker, we can now implement the entire stub in CSA. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2752143003 Cr-Original-Original-Commit-Position: refs/heads/master@{#44770} Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf Review-Url: https://codereview.chromium.org/2752143003 Cr-Original-Commit-Position: refs/heads/master@{#44775} Committed: https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a Review-Url: https://codereview.chromium.org/2752143003 Cr-Commit-Position: refs/heads/master@{#44779} Committed: https://chromium.googlesource.com/v8/v8/+/1a02b627b3dede3ee37c1ec00e0b5c4919749322

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix irregexp calls from runtime on arm,arm64,mips,mips64,ppc,s390 #

Patch Set 5 : Fix arm compilation #

Total comments: 6

Patch Set 6 : Update comments #

Total comments: 8

Patch Set 7 : Fix arg counts #

Patch Set 8 : Address comments #

Patch Set 9 : Revert sim-mips64 change #

Patch Set 10 : Revert sim-mips64 change #

Patch Set 11 : Fix non-sim arm64 and mips builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -950 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/simulator-arm.h View 1 2 3 4 5 6 2 chunks +5 lines, -10 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +2 lines, -7 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/bailout-reason.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins-regexp-gen.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp-gen.cc View 1 2 3 4 5 6 7 8 chunks +98 lines, -40 lines 0 comments Download
M src/code-factory.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 9 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/interface-descriptors.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/interface-descriptors.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/simulator-mips.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -10 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -80 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 2 3 4 5 6 8 3 chunks +3 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +0 lines, -71 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/ppc/simulator-ppc.h View 1 2 3 4 5 6 2 chunks +5 lines, -11 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.cc View 1 2 3 4 5 2 chunks +8 lines, -12 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 1 2 3 4 5 2 chunks +9 lines, -17 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.cc View 1 2 3 4 5 2 chunks +8 lines, -12 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 1 2 3 4 5 6 7 4 chunks +13 lines, -16 lines 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 1 2 3 4 5 2 chunks +4 lines, -8 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M src/regexp/s390/regexp-macro-assembler-s390.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/s390/regexp-macro-assembler-s390.cc View 1 2 3 4 5 2 chunks +4 lines, -8 lines 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/s390/simulator-s390.h View 1 2 3 4 5 6 2 chunks +5 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -79 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 71 (54 generated)
jgruber
Blocked by crbug.com/v8/6102.
3 years, 9 months ago (2017-03-21 11:39:02 UTC) #5
georgia.kouveli
Some minor comments about comments. https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regexp-macro-assembler-mips64.cc File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right): https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regexp-macro-assembler-mips64.cc#newcode79 src/regexp/mips64/regexp-macro-assembler-mips64.cc:79: * - fp[80] Isolate* ...
3 years, 8 months ago (2017-04-19 15:57:26 UTC) #22
jgruber
https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regexp-macro-assembler-mips64.cc File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right): https://codereview.chromium.org/2752143003/diff/80001/src/regexp/mips64/regexp-macro-assembler-mips64.cc#newcode79 src/regexp/mips64/regexp-macro-assembler-mips64.cc:79: * - fp[80] Isolate* isolate (address of the current ...
3 years, 8 months ago (2017-04-20 09:37:48 UTC) #25
jgruber
Reviewer's guide since this has become fairly large: * code-factory.{h,cc}: * code-stubs-*.cc: * interface-descriptors-*.cc: Removed ...
3 years, 8 months ago (2017-04-20 11:36:18 UTC) #29
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-regexp-gen.cc File src/builtins/builtins-regexp-gen.cc (right): https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-regexp-gen.cc#newcode384 src/builtins/builtins-regexp-gen.cc:384: // Argument 3: End of string ...
3 years, 8 months ago (2017-04-20 15:08:08 UTC) #34
jgruber
+mstarzinger for compiler/ (CallCFunction9) https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-regexp-gen.cc File src/builtins/builtins-regexp-gen.cc (right): https://codereview.chromium.org/2752143003/diff/100001/src/builtins/builtins-regexp-gen.cc#newcode384 src/builtins/builtins-regexp-gen.cc:384: // Argument 3: End of ...
3 years, 8 months ago (2017-04-21 10:42:33 UTC) #39
Michael Starzinger
LGTM.
3 years, 8 months ago (2017-04-21 11:14:10 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752143003/140001
3 years, 8 months ago (2017-04-21 11:44:39 UTC) #45
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf
3 years, 8 months ago (2017-04-21 11:46:31 UTC) #48
Michael Achenbach
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/2833083002/ by machenbach@chromium.org. ...
3 years, 8 months ago (2017-04-21 12:01:23 UTC) #49
Michael Achenbach
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/2827243005/ by machenbach@chromium.org. ...
3 years, 8 months ago (2017-04-21 12:01:35 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752143003/180001
3 years, 8 months ago (2017-04-21 12:35:50 UTC) #54
jgruber
On 2017/04/21 12:01:35, Michael Achenbach wrote: > A revert of this CL (patchset #8 id:140001) ...
3 years, 8 months ago (2017-04-21 12:36:23 UTC) #55
commit-bot: I haz the power
Committed patchset #10 (id:180001) as https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a
3 years, 8 months ago (2017-04-21 13:02:18 UTC) #58
jgruber
A revert of this CL (patchset #10 id:180001) has been created in https://codereview.chromium.org/2832193002/ by jgruber@chromium.org. ...
3 years, 8 months ago (2017-04-21 13:16:12 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752143003/200001
3 years, 8 months ago (2017-04-21 14:01:47 UTC) #68
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 14:03:43 UTC) #71
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/1a02b627b3dede3ee37c1ec00e0b5c49197...

Powered by Google App Engine
This is Rietveld 408576698