webkitpy: Reduce usage of path_from_webkit_base().

webkitpy: Reduce usage of path_from_webkit_base().

We'd like to make webkitpy robust against directory structure changes.

BUG=710535
Review-Url: https://codereview.chromium.org/2831883002
Cr-Commit-Position: refs/heads/master@{#466192}
Committed: https://chromium.googlesource.com/chromium/src/+/81b0fe590c56963e2665bec40cc6adf0718537a6

[tkent, 2017-04-20 07:59:10]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:59:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 08:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:16:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-04-20 12:06:13]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 12:06:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-04-20 12:13:00]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-20 13:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 13:32:15]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-20 14:56:45]

tkent@chromium.org changed reviewers:
+ qyearsley@chromium.org

[tkent, 2017-04-20 14:56:46]

qyearsley@, would you review this please?
This CL is the first step to hide path_from_webkit_base().

[qyearsley, 2017-04-20 23:25:22]

LGTM!

My main comment now is I'm wondering if we could think of other names for these
functions so that the names will still be reasonable after the blink move ...

Maybe it's reasonable to use these names for now but then later change them to
"path_from_web_dir", "path_from_tools_dir" or something like that?

https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py (right):

https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py:117: def
path_from_blink_source(self, *comps):
Later on, after the move, this will just be //web, since Source/ subdirectories
will be moved directly there, right?

https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py:127: return
self._filesystem.join(self._filesystem.join(self.webkit_base(), 'Tools',
'Scripts'), *comps)
I suppose later this will be be called path_from_tools or path_from_tools_dir,
right?

[tkent, 2017-04-20 23:48:11]

On 2017/04/20 at 23:25:22, qyearsley wrote:
> LGTM!
> 
> My main comment now is I'm wondering if we could think of other names for
these functions so that the names will still be reasonable after the blink move
...
> 
> Maybe it's reasonable to use these names for now but then later change them to
"path_from_web_dir", "path_from_tools_dir" or something like that?

That's right.

>
https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
> File third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
(right):
> 
>
https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
> third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py:117: def
path_from_blink_source(self, *comps):
> Later on, after the move, this will just be //web, since Source/
subdirectories will be moved directly there, right?

Right.

>
https://codereview.chromium.org/2831883002/diff/20001/third_party/WebKit/Tool...
> third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py:127: return
self._filesystem.join(self._filesystem.join(self.webkit_base(), 'Tools',
'Scripts'), *comps)
> I suppose later this will be be called path_from_tools or path_from_tools_dir,
right?

Right.
I wonder if we can name it "path_from_tools_dir" now, but I'm not sure if there
is a use-case for Tools/ not Tools/Scripts/.

[tkent, 2017-04-20 23:48:15]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-04-20 23:48:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 23:54:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492732095207310,
"parent_rev": "f7352cd198a784420184136e78cc14f85ff69c3a", "commit_rev":
"81b0fe590c56963e2665bec40cc6adf0718537a6"}

[commit-bot: I haz the power, 2017-04-20 23:54:22]

Description was changed from

==========
webkitpy: Reduce usage of path_from_webkit_base().

We'd like to make webkitpy robust against directory structure changes.

BUG=710535
==========

to

==========
webkitpy: Reduce usage of path_from_webkit_base().

We'd like to make webkitpy robust against directory structure changes.

BUG=710535

Review-Url: https://codereview.chromium.org/2831883002
Cr-Commit-Position: refs/heads/master@{#466192}
Committed:
https://chromium.googlesource.com/chromium/src/+/81b0fe590c56963e2665bec40cc6...
==========

[commit-bot: I haz the power, 2017-04-20 23:54:23]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81b0fe590c56963e2665bec40cc6...