third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py - Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base(). (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (C) 2011 Google Inc. All rights reserved.	1 # Copyright (C) 2011 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 if not self._git:	73 if not self._git:

74 self._git = MockGit(filesystem=self.filesystem, executive=self.execu tive, platform=self.platform)	74 self._git = MockGit(filesystem=self.filesystem, executive=self.execu tive, platform=self.platform)

75 # Various pieces of code (wrongly) call filesystem.chdir(checkout_root).	75 # Various pieces of code (wrongly) call filesystem.chdir(checkout_root).

76 # Making the checkout_root exist in the mock filesystem makes that chdir not raise.	76 # Making the checkout_root exist in the mock filesystem makes that chdir not raise.

77 self.filesystem.maybe_make_directory(self._git.checkout_root)	77 self.filesystem.maybe_make_directory(self._git.checkout_root)

78 return self._git	78 return self._git

79	79

80 def _add_base_manifest_to_mock_filesystem(self, filesystem):	80 def _add_base_manifest_to_mock_filesystem(self, filesystem):

81 webkit_finder = WebKitFinder(filesystem)	81 webkit_finder = WebKitFinder(filesystem)

82	82

83 external_dir = webkit_finder.path_from_webkit_base('LayoutTests', 'exter nal')	83 external_dir = webkit_finder.path_from_layout_tests('external')

84 filesystem.maybe_make_directory(filesystem.join(external_dir, 'wpt'))	84 filesystem.maybe_make_directory(filesystem.join(external_dir, 'wpt'))

85	85

86 manifest_base_path = filesystem.join(external_dir, 'WPT_BASE_MANIFEST.js on')	86 manifest_base_path = filesystem.join(external_dir, 'WPT_BASE_MANIFEST.js on')

87 filesystem.files[manifest_base_path] = '{}'	87 filesystem.files[manifest_base_path] = '{}'

OLD	NEW