third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py - Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py

Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base(). (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py

index 063792b496c8c30513cef8ea3f44a9daf9d82f33..69e1fe05e3962bab8e701ec431009d55e532748c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py

@@ -32,6 +32,7 @@ import os

import sys

import time

+from webkitpy.common.webkit_finder import WebKitFinder

from webkitpy.layout_tests.servers import server_base

@@ -55,7 +56,7 @@ class PyWebSocket(server_base.ServerBase):

time_str = time.strftime('%d%b%Y-%H%M%S')

log_file_name = _WS_LOG_PREFIX + time_str

self._error_log = self._filesystem.join(self._output_dir, log_file_name + '-err.txt')

- pywebsocket_base = self._port_obj.path_from_webkit_base('Tools', 'Scripts', 'webkitpy', 'thirdparty')

+ pywebsocket_base = WebKitFinder(self._filesystem).path_from_tools_scripts('webkitpy', 'thirdparty')

pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py')

self._start_cmd = [