third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2831883002: webkitpy: Reduce usage of path_from_webkit_base(). (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 3f3aabf488cac2367919f1162fb9d453af26a68e..cbcb91b2c4799cf48263c251538df02037ac0ba6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -537,7 +537,7 @@ class Manager(object):

_log.error("Upload failed: %s", err)

def _copy_results_html_file(self, destination_path):

- base_dir = self._port.path_from_webkit_base('LayoutTests', 'fast', 'harness')

+ base_dir = self._webkit_finder.path_from_layout_tests('fast', 'harness')

results_file = self._filesystem.join(base_dir, 'results.html')

# Note that the results.html template file won't exist when we're using a MockFileSystem during unit tests,

# so make sure it exists before we try to copy it.