Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2831753002: Node.prototype.baseURI should not be nullable (Closed)

Created:
3 years, 8 months ago by lpy
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Node.prototype.baseURI should not be nullable The definition of baseURI in Node.idl should be USVString. BUG=711562 Review-Url: https://codereview.chromium.org/2831753002 Cr-Commit-Position: refs/heads/master@{#465791} Committed: https://chromium.googlesource.com/chromium/src/+/0462cff6ac0ddd51d88e74eb2e356061bbe792b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
lpy
PTAL.
3 years, 8 months ago (2017-04-19 22:26:29 UTC) #6
tkent
lgtm
3 years, 8 months ago (2017-04-19 22:38:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831753002/1
3 years, 8 months ago (2017-04-19 22:39:39 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 22:45:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0462cff6ac0ddd51d88e74eb2e35...

Powered by Google App Engine
This is Rietveld 408576698