Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2831753002: Node.prototype.baseURI should not be nullable (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 3390 matching lines...) Expand 10 before | Expand all | Expand 10 after
3401 if (!EqualIgnoringFragmentIdentifier(old_base_url, base_url_)) { 3401 if (!EqualIgnoringFragmentIdentifier(old_base_url, base_url_)) {
3402 // Base URL change changes any relative visited links. 3402 // Base URL change changes any relative visited links.
3403 // FIXME: There are other URLs in the tree that would need to be 3403 // FIXME: There are other URLs in the tree that would need to be
3404 // re-evaluated on dynamic base URL change. Style should be invalidated too. 3404 // re-evaluated on dynamic base URL change. Style should be invalidated too.
3405 for (HTMLAnchorElement& anchor : 3405 for (HTMLAnchorElement& anchor :
3406 Traversal<HTMLAnchorElement>::StartsAfter(*this)) 3406 Traversal<HTMLAnchorElement>::StartsAfter(*this))
3407 anchor.InvalidateCachedVisitedLinkHash(); 3407 anchor.InvalidateCachedVisitedLinkHash();
3408 } 3408 }
3409 } 3409 }
3410 3410
3411 const KURL& Document::BaseURL() const {
3412 if (!base_url_.IsNull())
3413 return base_url_;
3414 return BlankURL();
3415 }
3416
3411 void Document::SetBaseURLOverride(const KURL& url) { 3417 void Document::SetBaseURLOverride(const KURL& url) {
3412 base_url_override_ = url; 3418 base_url_override_ = url;
3413 UpdateBaseURL(); 3419 UpdateBaseURL();
3414 } 3420 }
3415 3421
3416 void Document::ProcessBaseElement() { 3422 void Document::ProcessBaseElement() {
3417 UseCounter::Count(*this, UseCounter::kBaseElement); 3423 UseCounter::Count(*this, UseCounter::kBaseElement);
3418 3424
3419 // Find the first href attribute in a base element and the first target 3425 // Find the first href attribute in a base element and the first target
3420 // attribute in a base element. 3426 // attribute in a base element.
(...skipping 3244 matching lines...) Expand 10 before | Expand all | Expand 10 after
6665 } 6671 }
6666 6672
6667 void showLiveDocumentInstances() { 6673 void showLiveDocumentInstances() {
6668 WeakDocumentSet& set = liveDocumentSet(); 6674 WeakDocumentSet& set = liveDocumentSet();
6669 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6675 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6670 for (blink::Document* document : set) 6676 for (blink::Document* document : set)
6671 fprintf(stderr, "- Document %p URL: %s\n", document, 6677 fprintf(stderr, "- Document %p URL: %s\n", document,
6672 document->Url().GetString().Utf8().Data()); 6678 document->Url().GetString().Utf8().Data());
6673 } 6679 }
6674 #endif 6680 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/dom/Node.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698