third_party/WebKit/Source/core/dom/Document.cpp - Issue 2831753002: Node.prototype.baseURI should not be nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2831753002: Node.prototype.baseURI should not be nullable (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 019d228e16e8560e2a587c2fdf95ec8f42e634cb..132479ac3b63b1fa9c6d83d205fa297e923431b7 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -3408,6 +3408,12 @@ void Document::UpdateBaseURL() {

}

+const KURL& Document::BaseURL() const {

+ if (!base_url_.IsNull())

+ return base_url_;

+ return BlankURL();

void Document::SetBaseURLOverride(const KURL& url) {

base_url_override_ = url;

UpdateBaseURL();