third_party/WebKit/Source/core/dom/Document.h - Issue 2831753002: Node.prototype.baseURI should not be nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2831753002: Node.prototype.baseURI should not be nullable (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index 7ca96b55b74ba42ce0af49d812821773e35e79f2..94ddb813d78dd7e66347d099533054d91bb79d25 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -609,7 +609,7 @@ class CORE_EXPORT Document : public ContainerNode,

// To understand how these concepts relate to one another, please see the

// comments surrounding their declaration.

- const KURL& BaseURL() const { return base_url_; }

+ const KURL& BaseURL() const;

void SetBaseURLOverride(const KURL&);

const KURL& BaseURLOverride() const { return base_url_override_; }

KURL ValidBaseElementURL() const;