Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from DidClearWindowObject Remove redundant WebLocalFrame* parameter from DidClearWindowObject in WebFrameClient. Also updated relevant tests in WebFrameTest. BUG=361765 Review-Url: https://codereview.chromium.org/2831583004 Cr-Commit-Position: refs/heads/master@{#466579} Committed: https://chromium.googlesource.com/chromium/src/+/e40dfa1b230170ab32d3273313c2a606c6da8492

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M components/plugins/renderer/webview_plugin.h View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +7 lines, -9 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/web_frame_test_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/web_frame_test_proxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (12 generated)
sashab
3 years, 8 months ago (2017-04-20 06:29:04 UTC) #2
slangley
lgtm
3 years, 8 months ago (2017-04-21 00:52:11 UTC) #3
sashab
kinuko@ ptal at cotnent tkent@ ptal at webkit jochen@ ptal at components
3 years, 8 months ago (2017-04-21 00:53:30 UTC) #5
tkent
> tkent@ ptal at webkit lgtm
3 years, 8 months ago (2017-04-21 00:57:13 UTC) #6
kinuko
lgtm
3 years, 8 months ago (2017-04-21 00:57:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831583004/1
3 years, 8 months ago (2017-04-21 01:04:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/417147)
3 years, 8 months ago (2017-04-21 01:13:53 UTC) #11
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-21 08:42:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831583004/40001
3 years, 8 months ago (2017-04-24 00:23:23 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 02:13:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e40dfa1b230170ab32d3273313c2...

Powered by Google App Engine
This is Rietveld 408576698