content/shell/test_runner/web_frame_test_client.h - Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/web_frame_test_client.h

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/web_frame_test_client.h

diff --git a/content/shell/test_runner/web_frame_test_client.h b/content/shell/test_runner/web_frame_test_client.h

index 2989b76a1e139564f71ff459eba63b403f147bb2..be5c65fd09684fbad075c8c1a55d298907a4068f 100644

--- a/content/shell/test_runner/web_frame_test_client.h

+++ b/content/shell/test_runner/web_frame_test_client.h

@@ -94,7 +94,7 @@ class WebFrameTestClient : public blink::WebFrameClient {

const blink::WebString& sink_id,

const blink::WebSecurityOrigin& security_origin,

blink::WebSetSinkIdCallbacks* web_callbacks) override;

- void DidClearWindowObject(blink::WebLocalFrame* frame) override;

+ void DidClearWindowObject() override;

bool RunFileChooser(const blink::WebFileChooserParams& params,

blink::WebFileChooserCompletion* completion) override;

blink::WebEffectiveConnectionType GetEffectiveConnectionType() override;