Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/plugins/renderer/webview_plugin.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/webview_plugin.cc
diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc
index fd001151967372f39a62f27683e3238b40eb28cf..bb9eecff628892a020511304c3f55d31cca64c38 100644
--- a/components/plugins/renderer/webview_plugin.cc
+++ b/components/plugins/renderer/webview_plugin.cc
@@ -328,14 +328,14 @@ void WebViewPlugin::WebViewHelper::ScheduleAnimation() {
}
}
-void WebViewPlugin::WebViewHelper::DidClearWindowObject(WebLocalFrame* frame) {
- DCHECK_EQ(frame, web_view_->MainFrame());
+void WebViewPlugin::WebViewHelper::DidClearWindowObject() {
if (!plugin_->delegate_)
return;
v8::Isolate* isolate = blink::MainThreadIsolate();
v8::HandleScope handle_scope(isolate);
- v8::Local<v8::Context> context = frame->MainWorldScriptContext();
+ v8::Local<v8::Context> context =
+ web_view_->MainFrame()->MainWorldScriptContext();
DCHECK(!context.IsEmpty());
v8::Context::Scope context_scope(context);
« no previous file with comments | « components/plugins/renderer/webview_plugin.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698